From: "Xia, Chenbo" <chenbo.xia@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>, "jasowang@redhat.com" <jasowang@redhat.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com> Cc: "stable@dpdk.org" <stable@dpdk.org>, "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Zhang, Yuying" <yuying.zhang@intel.com>, "Singh, Aman Deep" <aman.deep.singh@intel.com> Subject: RE: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" Date: Mon, 16 May 2022 13:03:32 +0000 Message-ID: <SN6PR11MB35045DA4FC09169CA1F8D7009CCF9@SN6PR11MB3504.namprd11.prod.outlook.com> (raw) In-Reply-To: <20220505102729.821075-2-maxime.coquelin@redhat.com> + testpmd maintainers > -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Thursday, May 5, 2022 6:27 PM > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; > david.marchand@redhat.com; olivier.matz@6wind.com > Cc: stable@dpdk.org; Maxime Coquelin <maxime.coquelin@redhat.com> > Subject: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" > > This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum > forwarding"), > as the checksum forwarding is expected to only perform > checksum and not also overwritte the source and destination overwrites > MAC addresses. > > Doing so, we can test checksum offloading with real traffic > without breaking broadcast packets. > > Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") > Cc: stable@dpdk.org With above fixed: Acked-by: Chenbo Xia <chenbo.xia@intel.com> > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > app/test-pmd/csumonly.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index cdb1920763..8b6665d6f3 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -894,10 +894,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > * and inner headers */ > > eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *); > - rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], > - ð_hdr->dst_addr); > - rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, > - ð_hdr->src_addr); > parse_ethernet(eth_hdr, &info); > l3_hdr = (char *)eth_hdr + info.l2_len; > > -- > 2.35.1
next prev parent reply other threads:[~2022-05-16 13:04 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-05 10:27 [PATCH 0/6] Vhost checksum offload improvements Maxime Coquelin 2022-05-05 10:27 ` [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" Maxime Coquelin 2022-05-16 13:03 ` Xia, Chenbo [this message] 2022-05-17 15:24 ` Zhang, Yuying 2022-05-19 16:27 ` David Marchand 2022-05-05 10:27 ` [PATCH 2/6] vhost: fix missing enqueue pseudo-header calculation Maxime Coquelin 2022-05-16 13:24 ` Xia, Chenbo 2022-05-05 10:27 ` [PATCH 3/6] net/vhost: enable compliant offloading mode Maxime Coquelin 2022-05-16 13:26 ` Xia, Chenbo 2022-05-16 13:28 ` Maxime Coquelin 2022-05-16 13:39 ` Xia, Chenbo 2022-06-07 1:19 ` Ma, WenwuX 2022-06-08 8:19 ` Maxime Coquelin 2022-05-05 10:27 ` [PATCH 4/6] net/vhost: make VLAN stripping flag a boolean Maxime Coquelin 2022-05-16 13:27 ` Xia, Chenbo 2022-05-05 10:27 ` [PATCH 5/6] net/vhost: perform SW checksum in Rx path Maxime Coquelin 2022-05-05 10:27 ` [PATCH 6/6] net/vhost: perform SW checksum in Tx path Maxime Coquelin 2022-05-07 3:20 ` Ma, WenwuX 2022-06-02 9:07 ` Maxime Coquelin 2022-06-06 9:44 ` Ma, WenwuX 2022-06-08 8:14 ` Maxime Coquelin 2022-06-09 1:03 ` Ma, WenwuX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SN6PR11MB35045DA4FC09169CA1F8D7009CCF9@SN6PR11MB3504.namprd11.prod.outlook.com \ --to=chenbo.xia@intel.com \ --cc=aman.deep.singh@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=jasowang@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=olivier.matz@6wind.com \ --cc=stable@dpdk.org \ --cc=xiaoyun.li@intel.com \ --cc=yuying.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git