From: Maxime Coquelin <maxime.coquelin@redhat.com> To: "Xia, Chenbo" <chenbo.xia@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "jasowang@redhat.com" <jasowang@redhat.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com> Cc: "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [PATCH 3/6] net/vhost: enable compliant offloading mode Date: Mon, 16 May 2022 15:28:58 +0200 Message-ID: <b84231ff-e1aa-6773-89c6-8d46b42c7c80@redhat.com> (raw) In-Reply-To: <SN6PR11MB3504AE5102ABBDE155E7197C9CCF9@SN6PR11MB3504.namprd11.prod.outlook.com> Hi Chenbo, On 5/16/22 15:26, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin <maxime.coquelin@redhat.com> >> Sent: Thursday, May 5, 2022 6:27 PM >> To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; >> david.marchand@redhat.com; olivier.matz@6wind.com >> Cc: stable@dpdk.org; Maxime Coquelin <maxime.coquelin@redhat.com> >> Subject: [PATCH 3/6] net/vhost: enable compliant offloading mode >> >> This patch enables the compliant offloading flags mode by >> default, which prevents the Rx path to set Tx offload flags, >> which is illegal. A new legacy-ol-flags devarg is introduced >> to enable the legacy behaviour. >> >> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> >> --- >> doc/guides/nics/vhost.rst | 6 ++++++ >> drivers/net/vhost/rte_eth_vhost.c | 19 ++++++++++++++++--- >> 2 files changed, 22 insertions(+), 3 deletions(-) >> >> diff --git a/doc/guides/nics/vhost.rst b/doc/guides/nics/vhost.rst >> index ee802ec4a8..d7c0e2ade8 100644 >> --- a/doc/guides/nics/vhost.rst >> +++ b/doc/guides/nics/vhost.rst >> @@ -64,6 +64,12 @@ The user can specify below arguments in `--vdev` option. >> It is used to enable external buffer support in vhost library. >> (Default: 0 (disabled)) >> >> +#. ``legacy-ol-flags``: >> + >> + It is used to restore legacy behavior for offloading that was not >> + compliant with offloading API. >> + (Default: 0 (disabled)) >> + >> Vhost PMD event handling >> ------------------------ >> >> diff --git a/drivers/net/vhost/rte_eth_vhost.c >> b/drivers/net/vhost/rte_eth_vhost.c >> index 070f0e6dfd..0a2e8d9b29 100644 >> --- a/drivers/net/vhost/rte_eth_vhost.c >> +++ b/drivers/net/vhost/rte_eth_vhost.c >> @@ -31,9 +31,10 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM}; >> #define ETH_VHOST_CLIENT_ARG "client" >> #define ETH_VHOST_IOMMU_SUPPORT "iommu-support" >> #define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support" >> -#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" >> -#define ETH_VHOST_LINEAR_BUF "linear-buffer" >> -#define ETH_VHOST_EXT_BUF "ext-buffer" >> +#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" >> +#define ETH_VHOST_LINEAR_BUF "linear-buffer" >> +#define ETH_VHOST_EXT_BUF "ext-buffer" >> +#define ETH_VHOST_LEGACY_OL_FLAGS "legacy-ol-flags" >> #define VHOST_MAX_PKT_BURST 32 >> >> static const char *valid_arguments[] = { >> @@ -1563,6 +1564,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) >> int tso = 0; >> int linear_buf = 0; >> int ext_buf = 0; >> + int legacy_ol_flags = 0; >> struct rte_eth_dev *eth_dev; >> const char *name = rte_vdev_device_name(dev); >> >> @@ -1672,6 +1674,17 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) >> flags |= RTE_VHOST_USER_EXTBUF_SUPPORT; >> } >> >> + if (rte_kvargs_count(kvlist, ETH_VHOST_LEGACY_OL_FLAGS) == 1) { >> + ret = rte_kvargs_process(kvlist, >> + ETH_VHOST_LEGACY_OL_FLAGS, >> + &open_int, &legacy_ol_flags); >> + if (ret < 0) >> + goto out_free; >> + } >> + >> + if (legacy_ol_flags == 0) >> + flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS; > > Putting this check into above '{}' like other option does, will look better. Actually, it would change the behavior because we want to set the flag even if legacy devrarg is not passed. Regards, Maxime > Thanks, > Chenbo > >> + >> if (dev->device.numa_node == SOCKET_ID_ANY) >> dev->device.numa_node = rte_socket_id(); >> >> -- >> 2.35.1 >
next prev parent reply other threads:[~2022-05-16 13:29 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-05 10:27 [PATCH 0/6] Vhost checksum offload improvements Maxime Coquelin 2022-05-05 10:27 ` [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" Maxime Coquelin 2022-05-16 13:03 ` Xia, Chenbo 2022-05-17 15:24 ` Zhang, Yuying 2022-05-19 16:27 ` David Marchand 2022-05-05 10:27 ` [PATCH 2/6] vhost: fix missing enqueue pseudo-header calculation Maxime Coquelin 2022-05-16 13:24 ` Xia, Chenbo 2022-05-05 10:27 ` [PATCH 3/6] net/vhost: enable compliant offloading mode Maxime Coquelin 2022-05-16 13:26 ` Xia, Chenbo 2022-05-16 13:28 ` Maxime Coquelin [this message] 2022-05-16 13:39 ` Xia, Chenbo 2022-06-07 1:19 ` Ma, WenwuX 2022-06-08 8:19 ` Maxime Coquelin 2022-05-05 10:27 ` [PATCH 4/6] net/vhost: make VLAN stripping flag a boolean Maxime Coquelin 2022-05-16 13:27 ` Xia, Chenbo 2022-05-05 10:27 ` [PATCH 5/6] net/vhost: perform SW checksum in Rx path Maxime Coquelin 2022-05-05 10:27 ` [PATCH 6/6] net/vhost: perform SW checksum in Tx path Maxime Coquelin 2022-05-07 3:20 ` Ma, WenwuX 2022-06-02 9:07 ` Maxime Coquelin 2022-06-06 9:44 ` Ma, WenwuX 2022-06-08 8:14 ` Maxime Coquelin 2022-06-09 1:03 ` Ma, WenwuX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b84231ff-e1aa-6773-89c6-8d46b42c7c80@redhat.com \ --to=maxime.coquelin@redhat.com \ --cc=chenbo.xia@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=jasowang@redhat.com \ --cc=olivier.matz@6wind.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git