From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
<stable@dpdk.org>
Subject: Re: [PATCH] hash: fix GFNI implementation build with GCC 12
Date: Mon, 9 Jan 2023 10:24:00 +0000 [thread overview]
Message-ID: <Y7vrQCxebK27ac+U@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230109100337.714937-1-david.marchand@redhat.com>
On Mon, Jan 09, 2023 at 11:03:37AM +0100, David Marchand wrote:
> On a system that has AVX512F and GFNI, compiling fails with:
>
> In file included from /usr/lib/gcc/x86_64-redhat-linux/12/include/immintrin.h:71,
> from /usr/lib/gcc/x86_64-redhat-linux/12/include/x86intrin.h:32,
> from ../../../git/pub/dpdk.org/main/lib/eal/x86/include/rte_vect.h:31,
> from ../../../git/pub/dpdk.org/main/lib/eal/x86/include/rte_memcpy.h:17,
> from ../../../git/pub/dpdk.org/main/lib/mempool/rte_mempool.h:48,
> from ../../../git/pub/dpdk.org/main/lib/mbuf/rte_mbuf.h:38,
> from ../../../git/pub/dpdk.org/main/lib/net/rte_ip.h:33,
> from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.h:25,
> from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:7:
> In function ‘_mm512_mask_permutexvar_epi8’,
> inlined from ‘__rte_thash_gfni’ at
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:142:17,
> inlined from ‘rte_thash_gfni’ at
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:182:20,
> inlined from ‘rte_thash_adjust_tuple’ at
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:784:11:
> /usr/lib/gcc/x86_64-redhat-linux/12/include/avx512vbmiintrin.h:97:20:
> error: ‘tuple_bytes’ may be used uninitialized [-Werror=maybe-uninitialized]
> 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __B,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 98 | (__v64qi) __A,
> | ~~~~~~~~~~~~~~
> 99 | (__v64qi) __W,
> | ~~~~~~~~~~~~~~
> 100 | (__mmask64) __M);
> | ~~~~~~~~~~~~~~~~
>
> And:
>
> In file included from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_gfni.h:17,
> from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.h:27:
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:
> In function ‘rte_thash_adjust_tuple’:
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:91:33:
> note: ‘tuple_bytes’ was declared here
> 91 | __m512i vals, matrixes, tuple_bytes, tuple_bytes_2;
> | ^~~~~~~~~~~
> In function ‘_mm512_mask_permutexvar_epi8’,
> inlined from ‘__rte_thash_gfni’ at
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:142:17,
> inlined from ‘rte_thash_gfni’ at
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:182:20,
> inlined from ‘rte_thash_adjust_tuple’ at
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:784:11:
> /usr/lib/gcc/x86_64-redhat-linux/12/include/avx512vbmiintrin.h:97:20:
> error: ‘permute_mask’ may be used uninitialized [-Werror=maybe-uninitialized]
> 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __B,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 98 | (__v64qi) __A,
> | ~~~~~~~~~~~~~~
> 99 | (__v64qi) __W,
> | ~~~~~~~~~~~~~~
> 100 | (__mmask64) __M);
> | ~~~~~~~~~~~~~~~~
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:
> In function ‘rte_thash_adjust_tuple’:
> ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:92:30:
> note: ‘permute_mask’ was declared here
> 92 | __mmask64 load_mask, permute_mask, permute_mask_2;
> | ^~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Set those variables to 0.
>
> Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/hash/rte_thash_x86_gfni.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Hit this issue myself before, but somehow never got to pushing out a patch
for it. Thanks for doing so.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2023-01-09 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 10:03 David Marchand
2023-01-09 10:24 ` Bruce Richardson [this message]
2023-01-09 17:47 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7vrQCxebK27ac+U@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).