Re: [EXT] Re: [PATCH 20.11] net/octeontx2: fix flow MCAM priority management

[Luca Boccassi <bluca@debian.org>]

On Tue, 2022-03-15 at 12:46 +0000, Satheesh Paul wrote:
> Hi,
> 
> Yes, the issue is specific to 20.11. On main branch this part of the code has been fully rewritten. (1f66919817 common/cnxk: improve MCAM entries management).
> This is now backported with this patch to address the issue.
> 
> Thanks,
> Satheesh. 

Ok, please get at least one more person to review and ack it then - I
do not know nearly enough about this PMD to do a meaningful review.

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org> 
> Sent: 15 March 2022 05:14 PM
> To: Satheesh Paul <psatheesh@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
> Cc: stable@dpdk.org
> Subject: [EXT] Re: [PATCH 20.11] net/octeontx2: fix flow MCAM priority management
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Tue, 2022-03-15 at 09:46 +0530, psatheesh@marvell.com wrote:
> > From: Satheesh Paul <psatheesh@marvell.com>
> > 
> > This patch fixes issues in rearranging the MCAM entries when user is 
> > creating flows with priority levels.
> > The MCAM preallocation scheme and the free entry cache are removed. 
> > For every flow created, an MCAM allocation request is made to the 
> > kernel. Each priority level has a list of MCAM entries. For every flow 
> > rule added, the MCAM entry obtained from kernel is checked if it is at 
> > the correct user specified priority. If not, the existing rules are 
> > moved across MCAM entries so that the user specified priority is 
> > maintained.
> > 
> > Fixes: 29a2017c70 ("net/octeontx2: add flow mbox utility functions")
> > 
> > Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> > ---
> >  drivers/net/octeontx2/otx2_flow.c       | 145 +----
> >  drivers/net/octeontx2/otx2_flow.h       |  33 +-
> >  drivers/net/octeontx2/otx2_flow_utils.c | 717 
> > ++++++++++++------------
> >  3 files changed, 405 insertions(+), 490 deletions(-)
> 
> Hi,
> 
> I don't see this patch on main - is it a bug specific to 20.11?
> 
> --
> Kind regards,
> Luca Boccassi