* [PATCH] net/sfc: account for data offset on Tx
@ 2023-09-11 10:47 Viacheslav Galaktionov
2023-09-11 13:06 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Viacheslav Galaktionov @ 2023-09-11 10:47 UTC (permalink / raw)
To: dev; +Cc: stable, Ivan Malov, Andy Moreton, Andrew Rybchenko
Memory buffers passed by the application may contain private data,
which must not be sent to the NIC. Omit this private data by using
the actual data address instead of the default one.
Fixes: 3037e6cf3dde ("net/sfc: support regioned NIC DMA memory mapping type")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
Reviewed-by: Ivan Malov <ivan.malov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
drivers/net/sfc/sfc_ef100_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c
index 4c2205f7a4..1b6374775f 100644
--- a/drivers/net/sfc/sfc_ef100_tx.c
+++ b/drivers/net/sfc/sfc_ef100_tx.c
@@ -405,7 +405,7 @@ sfc_ef100_tx_qdesc_send_create(const struct sfc_ef100_txq *txq,
m->l2_len + m->l3_len) >> 1;
}
- rc = sfc_ef100_tx_map(txq, rte_mbuf_data_iova_default(m),
+ rc = sfc_ef100_tx_map(txq, rte_mbuf_data_iova(m),
rte_pktmbuf_data_len(m), &dma_addr);
if (unlikely(rc != 0))
return rc;
--
2.42.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/sfc: account for data offset on Tx
2023-09-11 10:47 [PATCH] net/sfc: account for data offset on Tx Viacheslav Galaktionov
@ 2023-09-11 13:06 ` Andrew Rybchenko
2023-09-11 14:55 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2023-09-11 13:06 UTC (permalink / raw)
To: Viacheslav Galaktionov, dev; +Cc: stable, Ivan Malov, Andy Moreton
On 9/11/23 13:47, Viacheslav Galaktionov wrote:
> Memory buffers passed by the application may contain private data,
> which must not be sent to the NIC. Omit this private data by using
> the actual data address instead of the default one.
>
> Fixes: 3037e6cf3dde ("net/sfc: support regioned NIC DMA memory mapping type")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
> Reviewed-by: Ivan Malov <ivan.malov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/sfc: account for data offset on Tx
2023-09-11 13:06 ` Andrew Rybchenko
@ 2023-09-11 14:55 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2023-09-11 14:55 UTC (permalink / raw)
To: stable
On 9/11/2023 2:06 PM, Andrew Rybchenko wrote:
> On 9/11/23 13:47, Viacheslav Galaktionov wrote:
>> Memory buffers passed by the application may contain private data,
>> which must not be sent to the NIC. Omit this private data by using
>> the actual data address instead of the default one.
>>
>> Fixes: 3037e6cf3dde ("net/sfc: support regioned NIC DMA memory mapping
>> type")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Viacheslav Galaktionov
>> <viacheslav.galaktionov@arknetworks.am>
>> Reviewed-by: Ivan Malov <ivan.malov@arknetworks.am>
>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-11 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 10:47 [PATCH] net/sfc: account for data offset on Tx Viacheslav Galaktionov
2023-09-11 13:06 ` Andrew Rybchenko
2023-09-11 14:55 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).