From: Luca Boccassi <bluca@debian.org>
To: Kevin Traynor <ktraynor@redhat.com>,
stable@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-stable] [PATCH 18.11] kni: fix ethtool build error on kernel 5.9
Date: Mon, 23 Nov 2020 15:05:35 +0000 [thread overview]
Message-ID: <bf515e135a6f1ebe8423317bded5f03b40cbe452.camel@debian.org> (raw)
In-Reply-To: <20201123144948.40420-1-ktraynor@redhat.com>
On Mon, 2020-11-23 at 14:49 +0000, Kevin Traynor wrote:
> read_barrier_depends() is removed from kernel 5.9 as per Linux
> commit 93fab07c2293 ("locking/barriers: Remove definitions for [smp_]read_barrier_depends()")
>
> It is used by ethtool and produces an error when building on kernel 5.9:
>
> /kernel/linux/kni/ethtool/igb/igb_main.c: In function ‘igb_clean_tx_irq’:
> /dpdk-stable/kernel/linux/kni/ethtool/igb/igb_main.c:7067:3:
> error: implicit declaration of function ‘read_barrier_depends’
> [-Werror=implicit-function-declaration]
> 7067 | read_barrier_depends();
> | ^~~~~~~~~~~~~~~~~~~~
>
> Fix by replacing with rmb() as is done for < 2.6 kernels.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> kernel/linux/kni/ethtool/igb/kcompat.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
> index 459fda3dad..e89033818a 100644
> --- a/kernel/linux/kni/ethtool/igb/kcompat.h
> +++ b/kernel/linux/kni/ethtool/igb/kcompat.h
> @@ -3974,3 +3974,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> #endif
>
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 9, 0)
> +#define read_barrier_depends() rmb()
> +#endif
> +
> #endif /* _KCOMPAT_H_ */
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2020-11-23 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 14:49 Kevin Traynor
2020-11-23 15:05 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf515e135a6f1ebe8423317bded5f03b40cbe452.camel@debian.org \
--to=bluca@debian.org \
--cc=ferruh.yigit@intel.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).