* [dpdk-stable] [PATCH] net/mlx5: fix Tx when first segment size is too short
@ 2017-03-29 7:32 Nelio Laranjeiro
2017-03-29 7:51 ` Nelio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2017-03-29 7:32 UTC (permalink / raw)
To: dev; +Cc: Adrien Mazarguil, Yongseok Koh, stable
First segment size must be 18 bytes, packets not respecting this are
silently not sent by the NIC but counted as sent by the PMD.
The only way to figure out is compiling the PMD in debug mode.
Cc: stable@dpdk.org
Fixes: 6579c27c11a5 ("net/mlx5: remove gather loop on segments")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 823aac8..e2e8a22 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -485,7 +485,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
#ifdef MLX5_PMD_SOFT_COUNTERS
total_length = length;
#endif
- assert(length >= MLX5_WQE_DWORD_SIZE);
+ if (length < (MLX5_WQE_DWORD_SIZE + 2))
+ break;
/* Update element. */
(*txq->elts)[elts_head] = buf;
elts_head = (elts_head + 1) & (elts_n - 1);
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-stable] [PATCH] net/mlx5: fix Tx when first segment size is too short
2017-03-29 7:32 [dpdk-stable] [PATCH] net/mlx5: fix Tx when first segment size is too short Nelio Laranjeiro
@ 2017-03-29 7:51 ` Nelio Laranjeiro
2017-03-30 16:32 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2017-03-29 7:51 UTC (permalink / raw)
To: dev; +Cc: Adrien Mazarguil, Yongseok Koh, stable
First segment size must be at least 18 bytes, packets not respecting this
are silently not sent by the NIC but counted as sent by the PMD. The only
way to figure out is compiling the PMD in debug mode.
Cc: stable@dpdk.org
Fixes: 6579c27c11a5 ("net/mlx5: remove gather loop on segments")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
v2: fix the commit log.
---
drivers/net/mlx5/mlx5_rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 823aac8..e2e8a22 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -485,7 +485,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)
#ifdef MLX5_PMD_SOFT_COUNTERS
total_length = length;
#endif
- assert(length >= MLX5_WQE_DWORD_SIZE);
+ if (length < (MLX5_WQE_DWORD_SIZE + 2))
+ break;
/* Update element. */
(*txq->elts)[elts_head] = buf;
elts_head = (elts_head + 1) & (elts_n - 1);
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] net/mlx5: fix Tx when first segment size is too short
2017-03-29 7:51 ` Nelio Laranjeiro
@ 2017-03-30 16:32 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-03-30 16:32 UTC (permalink / raw)
To: Nelio Laranjeiro, dev; +Cc: Adrien Mazarguil, Yongseok Koh, stable
On 3/29/2017 8:51 AM, Nelio Laranjeiro wrote:
> First segment size must be at least 18 bytes, packets not respecting this
> are silently not sent by the NIC but counted as sent by the PMD. The only
> way to figure out is compiling the PMD in debug mode.
>
> Cc: stable@dpdk.org
> Fixes: 6579c27c11a5 ("net/mlx5: remove gather loop on segments")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-30 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-29 7:32 [dpdk-stable] [PATCH] net/mlx5: fix Tx when first segment size is too short Nelio Laranjeiro
2017-03-29 7:51 ` Nelio Laranjeiro
2017-03-30 16:32 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).