From: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: stable@dpdk.org, Chao Zhu <chaozhu@linux.vnet.ibm.com>,
Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Subject: [dpdk-stable] [PATCH 3/3] eal: reverse powerpc changes done for hugepage overcommit
Date: Thu, 21 Jun 2018 10:57:38 +0530 [thread overview]
Message-ID: <e55d126ec4d50b6137ac58eafb951802f8e5f254.1527076172.git.gowrishankar.m@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1527076172.git.gowrishankar.m@linux.vnet.ibm.com>
In-Reply-To: <cover.1527076172.git.gowrishankar.m@linux.vnet.ibm.com>
From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Reverse the previous changes done for multiprocess support, as it is
addressed without relying in nr_overcommit_hugepages in powerpc.
Fixes: 284ae3e9ff ("eal/ppc: fix mmap for memory initialization")
Cc: stable@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
---
doc/guides/linux_gsg/sys_reqs.rst | 6 ------
lib/librte_eal/linuxapp/eal/eal_memory.c | 8 --------
2 files changed, 14 deletions(-)
diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst
index 3e7fe63..ee69c1a 100644
--- a/doc/guides/linux_gsg/sys_reqs.rst
+++ b/doc/guides/linux_gsg/sys_reqs.rst
@@ -207,12 +207,6 @@ On a NUMA machine, pages should be allocated explicitly on separate nodes::
For 1G pages, it is not possible to reserve the hugepage memory after the system has booted.
- On IBM POWER system, the nr_overcommit_hugepages should be set to the same value as nr_hugepages.
- For example, if the required page number is 128, the following commands are used::
-
- echo 128 > /sys/kernel/mm/hugepages/hugepages-16384kB/nr_hugepages
- echo 128 > /sys/kernel/mm/hugepages/hugepages-16384kB/nr_overcommit_hugepages
-
Using Hugepages with the DPDK
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index 3dcd6c2..56515cc 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -280,11 +280,7 @@
do {
addr = mmap(addr,
(*size) + hugepage_sz, PROT_READ,
-#ifdef RTE_ARCH_PPC_64
- MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB,
-#else
MAP_PRIVATE,
-#endif
fd, 0);
if (addr == MAP_FAILED)
*size -= hugepage_sz;
@@ -1397,11 +1393,7 @@ void numa_error(char *where)
*/
base_addr = mmap(mcfg->memseg[s].addr, mcfg->memseg[s].len,
PROT_READ,
-#ifdef RTE_ARCH_PPC_64
- MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB,
-#else
MAP_PRIVATE,
-#endif
fd_zero, 0);
if (base_addr == MAP_FAILED ||
base_addr != mcfg->memseg[s].addr) {
--
1.9.1
next prev parent reply other threads:[~2018-06-21 5:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 12:53 [dpdk-stable] [PATCH 0/3] eal: clean up mapping hugepages in secondary process for ppc64le Gowrishankar
2018-06-21 5:27 ` Gowrishankar
2018-06-21 5:27 ` [dpdk-stable] [PATCH 1/3] eal: access hugepage_file in reverse order for powerpc Gowrishankar
2018-06-21 5:27 ` [dpdk-stable] [PATCH 2/3] eal: reorder calling munmap on zero-mapped memory Gowrishankar
2018-06-21 5:27 ` Gowrishankar [this message]
2018-06-21 8:50 ` [dpdk-stable] [PATCH 0/3] eal: clean up mapping hugepages in secondary process for ppc64le Luca Boccassi
2018-06-21 8:54 ` gowrishankar muthukrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e55d126ec4d50b6137ac58eafb951802f8e5f254.1527076172.git.gowrishankar.m@linux.vnet.ibm.com \
--to=gowrishankar.m@linux.vnet.ibm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=konstantin.ananyev@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).