[dpdk-stable] [PATCH 19.11] test/crypto: fix statistics case

[dpdk-stable] [PATCH 19.11] test/crypto: fix statistics case

[Apeksha Gupta]

[ upstream commit 29fdc5bf4555e16e866188dd9fe95f9bab01404a ]

The test case - test_stats is directly accessing the
cryptodev and its dev_ops which are internal to library
and should not be used directly by the application.
However, the test case is also missing to check for the
error ENOTSUP. It should skip the case if the API returns
ENOTSUP. This patch fixes these two issues.

Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Cc: stable@dpdk.org

Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 app/test/test_cryptodev.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 79ced809d..db9dd3aec 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -9158,8 +9158,10 @@ test_stats(void)
 {
 	struct crypto_testsuite_params *ts_params = &testsuite_params;
 	struct rte_cryptodev_stats stats;
-	struct rte_cryptodev *dev;
-	cryptodev_stats_get_t temp_pfn;
+
+	if (rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats)
+			== -ENOTSUP)
+		return -ENOTSUP;
 
 	rte_cryptodev_stats_reset(ts_params->valid_devs[0]);
 	TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0] + 600,
@@ -9167,13 +9169,6 @@ test_stats(void)
 		"rte_cryptodev_stats_get invalid dev failed");
 	TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], 0) != 0),
 		"rte_cryptodev_stats_get invalid Param failed");
-	dev = &rte_cryptodevs[ts_params->valid_devs[0]];
-	temp_pfn = dev->dev_ops->stats_get;
-	dev->dev_ops->stats_get = (cryptodev_stats_get_t)0;
-	TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats)
-			== -ENOTSUP),
-		"rte_cryptodev_stats_get invalid Param failed");
-	dev->dev_ops->stats_get = temp_pfn;
 
 	/* Test expected values */
 	ut_setup();
-- 
2.17.1

Re: [dpdk-stable] [PATCH 19.11] test/crypto: fix statistics case

[Luca Boccassi]

On Wed, 2020-06-03 at 18:47 +0530, Apeksha Gupta wrote:
> [ upstream commit 29fdc5bf4555e16e866188dd9fe95f9bab01404a ]
> 
> The test case - test_stats is directly accessing the
> cryptodev and its dev_ops which are internal to library
> and should not be used directly by the application.
> However, the test case is also missing to check for the
> error ENOTSUP. It should skip the case if the API returns
> ENOTSUP. This patch fixes these two issues.
> 
> Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  app/test/test_cryptodev.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)

Thanks, applied and pushed.

-- 
Kind regards,
Luca Boccassi