From: Aaron Conole <aconole@redhat.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: "Pattan\, Reshma" <reshma.pattan@intel.com>, David Marchand <david.marchand@redhat.com>, "Rao\, Nikhil" <nikhil.rao@intel.com>, dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>, Chas Williams <chas3@att.com>, "Richardson\, Bruce" <bruce.richardson@intel.com>, Stephen Hemminger <stephen@networkplumber.org> Subject: Re: [dpdk-stable] [PATCH v3] app/test: fix build when ring PMD is disabled Date: Mon, 09 Dec 2019 13:00:31 -0500 Message-ID: <f7t8snlgz0g.fsf@dhcp-25.97.bos.redhat.com> (raw) In-Reply-To: <b5ec5fe6-1e29-11a9-036a-1a0d9afd8d0d@intel.com> (Ferruh Yigit's message of "Mon, 9 Dec 2019 16:54:52 +0000") Ferruh Yigit <ferruh.yigit@intel.com> writes: > On 12/9/2019 1:38 PM, Pattan, Reshma wrote: >> >> >>>>> -----Original Message----- >>>>> From: David Marchand <david.marchand@redhat.com> >>>>>> v3: add missing test event_eth_tx_adapter_autotest. >> >> Just wondering, if is it ok to send me the v4 by reverting the test >> case addition from run for this patch to get accepted, as fixing the >> test case can be handled separately. > > Is the root cause of the failures missing '-d' parameter, why not provide that > instead of not executing the test cases? +1 > David, Aaron, Can it be possible to test providing '-d' paramter in travis and > see if it fixes the issue? It's always possible. The best way would be to use one's own github repo and travis-ci instance to test the changes and ensure they are correct. It's also possible to submit a patch to the list that has the change and it will be applied and a build + test should happen. > And what do you think splitting the patch into two, one fixes the build issues > and other adding the missing testcases to the test suit? > > >> >>>> Is this something that Nikhil should look into this as maintainer and fix in >>> separate patch, I am afraid this is not my area of expertise. >>> >>> I agree that someone knowing of this test should be looking at it. >>> >>> My suggestion on adding this test was based on the fact that we were building >>> this code test. >>> But I was expecting that you test this addition. >>> >>> You shall not break the CI :-) +1000 to this >>> Please add this to your checklist for future submissions, or at least check the >>> robot reports. >>> >>> >>> Thanks. >>> >>> -- >>> David Marchand >>
next prev parent reply other threads:[~2019-12-09 18:00 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-17 9:41 [dpdk-stable] [PATCH 1/2] app/test: fix make " Reshma Pattan 2019-10-17 9:41 ` [dpdk-stable] [PATCH 2/2] app/test: fix meson " Reshma Pattan 2019-10-17 9:51 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson 2019-10-17 9:54 ` [dpdk-stable] " David Marchand 2019-10-17 9:48 ` [dpdk-stable] [PATCH 1/2] app/test: fix make " Bruce Richardson 2019-10-17 11:16 ` [dpdk-stable] [PATCH v2] app/test: fix " Reshma Pattan 2019-10-17 13:46 ` Bruce Richardson 2019-10-25 8:11 ` [dpdk-stable] [dpdk-dev] " David Marchand 2019-10-25 15:40 ` Pattan, Reshma 2019-10-25 15:38 ` [dpdk-stable] [PATCH v3] " Reshma Pattan 2019-10-27 8:47 ` David Marchand 2019-10-29 9:36 ` Pattan, Reshma 2019-10-31 7:58 ` David Marchand 2019-10-31 10:18 ` Pattan, Reshma 2019-12-09 13:38 ` Pattan, Reshma 2019-12-09 16:54 ` Ferruh Yigit 2019-12-09 18:00 ` Aaron Conole [this message] 2019-12-18 11:58 ` [dpdk-stable] [PATCH v4] " Reshma Pattan 2019-12-18 16:07 ` Bruce Richardson 2019-12-18 16:23 ` Pattan, Reshma 2019-12-23 6:53 ` [dpdk-stable] [PATCH v5] " Reshma Pattan 2020-01-19 21:50 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 2020-01-20 9:55 ` Rao, Nikhil 2020-01-20 17:36 ` [dpdk-stable] " Bruce Richardson 2020-02-16 18:10 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f7t8snlgz0g.fsf@dhcp-25.97.bos.redhat.com \ --to=aconole@redhat.com \ --cc=bruce.richardson@intel.com \ --cc=chas3@att.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=nikhil.rao@intel.com \ --cc=reshma.pattan@intel.com \ --cc=stable@dpdk.org \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git