From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: hgovindh <hariprasad.govindharajan@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Ori Kam <orika@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>
Cc: dev@dpdk.org, drc@linux.vnet.ibm.com, ruifeng.wang@arm.com,
maciej.czekaj@caviumnetworks.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] examples/l3fwd: fix unaligned memory access
Date: Fri, 26 Jul 2019 14:37:35 +0100 [thread overview]
Message-ID: <fc45141a-a75d-1af4-0415-549f6c4d83bb@intel.com> (raw)
In-Reply-To: <20190726132758.55217-1-hariprasad.govindharajan@intel.com>
On 26-Jul-19 2:27 PM, hgovindh wrote:
> Fix unaligned memory access when reading IPv6 header which
> leads to segmentation fault by changing aligned memory read
> to unaligned memory read.
>
> Bugzilla ID: 279
> Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build")
> Cc: maciej.czekaj@caviumnetworks.com
> Cc: stable@dpdk.org
> Signed-off-by: hgovindh <hariprasad.govindharajan@intel.com>
> ---
> V2: Added functions which will do unaligned load based on the
> underlying architecture
>
> V3: Removed functions added in V2 and replaced them with if macros
> which will branch based on the underlying architecture. As per my
> understanding since the unaligned load affects only Intel arch,
> I added that function branch and left the original code for other arc.
> Can someone with ARM and PowerPC arch, could you please validate this
> patch and let me know?
> ---
> examples/l3fwd/l3fwd_em.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c
> index 5f499e005..ea9ca9491 100644
> --- a/examples/l3fwd/l3fwd_em.c
> +++ b/examples/l3fwd/l3fwd_em.c
> @@ -244,6 +244,7 @@ em_mask_key(void *key, xmm_t mask)
> #error No vector engine (SSE, NEON, ALTIVEC) available, check your toolchain
> #endif
>
> +
> static inline uint16_t
Unintended whitespace change?
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-07-26 13:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 16:43 [dpdk-stable] [PATCH] " hgovindh
2019-07-25 7:01 ` [dpdk-stable] [dpdk-dev] " Ruifeng Wang (Arm Technology China)
2019-07-25 9:05 ` [dpdk-stable] " Bruce Richardson
2019-07-25 13:27 ` [dpdk-stable] [dpdk-dev] " Aaron Conole
2019-07-25 14:01 ` Burakov, Anatoly
2019-07-25 14:08 ` Govindharajan, Hariprasad
2019-07-25 14:01 ` Lipiec, Herakliusz
2019-07-25 14:23 ` Burakov, Anatoly
2019-07-25 16:29 ` [dpdk-stable] [PATCH v2] " hgovindh
2019-07-25 16:46 ` Bruce Richardson
2019-07-25 17:14 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob Kollanukkaran
2019-07-25 18:56 ` David Christensen
2019-07-25 22:06 ` David Christensen
2019-07-26 10:58 ` [dpdk-stable] [EXT] " Jerin Jacob Kollanukkaran
2019-07-26 13:27 ` [dpdk-stable] [PATCH v3] " hgovindh
2019-07-26 13:37 ` Burakov, Anatoly [this message]
2019-07-26 13:58 ` [dpdk-stable] [PATCH v4] " hgovindh
2019-07-30 8:50 ` Thomas Monjalon
2019-07-30 9:47 ` Bruce Richardson
2019-07-30 11:03 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob Kollanukkaran
2019-07-30 17:45 ` David Christensen
2019-07-31 1:27 ` Ruifeng Wang (Arm Technology China)
2019-07-30 13:26 ` [dpdk-stable] [PATCH v5] Examples/l3fwd: " Hariprasad Govindharajan
2019-07-30 15:48 ` [dpdk-stable] [dpdk-dev] " Lipiec, Herakliusz
2019-07-30 19:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc45141a-a75d-1af4-0415-549f6c4d83bb@intel.com \
--to=anatoly.burakov@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=hariprasad.govindharajan@intel.com \
--cc=maciej.czekaj@caviumnetworks.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).