From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Leyi Rong <leyi.rong@intel.com>
Subject: [dpdk-test-report] |WARNING| pw55004 [PATCH v3 17/69] net/ice/base: use macro instead of magic 8
Date: Wed, 19 Jun 2019 17:38:47 +0200 (CEST) [thread overview]
Message-ID: <20190619153847.A822A1D0BF@dpdk.org> (raw)
In-Reply-To: <20190619151846.113820-18-leyi.rong@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55004
_coding style issues_
CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_offset_bytes' may be better as '(_offset_bytes)' to avoid precedence issues
#71: FILE: drivers/net/ice/base/ice_flow.c:39:
+#define ICE_FLOW_FLD_INFO(_hdr, _offset_bytes, _size_bytes) { \
+ .hdr = _hdr, \
+ .off = _offset_bytes * BITS_PER_BYTE, \
+ .size = _size_bytes * BITS_PER_BYTE, \
+}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_size_bytes' may be better as '(_size_bytes)' to avoid precedence issues
#71: FILE: drivers/net/ice/base/ice_flow.c:39:
+#define ICE_FLOW_FLD_INFO(_hdr, _offset_bytes, _size_bytes) { \
+ .hdr = _hdr, \
+ .off = _offset_bytes * BITS_PER_BYTE, \
+ .size = _size_bytes * BITS_PER_BYTE, \
+}
total: 0 errors, 0 warnings, 2 checks, 157 lines checked
parent reply other threads:[~2019-06-19 15:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190619151846.113820-18-leyi.rong@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619153847.A822A1D0BF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).