From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: [dpdk-test-report] |WARNING| pw63782 [PATCH] app/test-fib: add test-fib application
Date: Wed, 11 Dec 2019 19:45:59 +0100 (CET) [thread overview]
Message-ID: <20191211184559.2E23F34EF@dpdk.org> (raw)
In-Reply-To: <47c912c650adf1461634807af1ad086841e19187.1576089843.git.vladimir.medvedkin@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/63782
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#121: FILE: app/test-fib/main.c:26:
+#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \
+ unsigned long val; \
+ char *end_fld; \
+ errno = 0; \
+ val = strtoul((in), &end_fld, (base)); \
+ if (errno != 0 || end_fld[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof(fd))val; \
+ (in) = end_fld + 1; \
+} while (0)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#158: FILE: app/test-fib/main.c:63:
+#define NIPQUAD(addr) \
+ (unsigned)((unsigned char *)&addr)[3], \
+ (unsigned)((unsigned char *)&addr)[2], \
+ (unsigned)((unsigned char *)&addr)[1], \
+ (unsigned)((unsigned char *)&addr)[0]
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#159: FILE: app/test-fib/main.c:64:
+ (unsigned)((unsigned char *)&addr)[3], \
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#160: FILE: app/test-fib/main.c:65:
+ (unsigned)((unsigned char *)&addr)[2], \
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#161: FILE: app/test-fib/main.c:66:
+ (unsigned)((unsigned char *)&addr)[1], \
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#162: FILE: app/test-fib/main.c:67:
+ (unsigned)((unsigned char *)&addr)[0]
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#165: FILE: app/test-fib/main.c:70:
+#define NIPQUAD6(addr) \
+ ((uint8_t *)addr)[0] << 8 | \
+ ((uint8_t *)addr)[1], \
+ ((uint8_t *)addr)[2] << 8 | \
+ ((uint8_t *)addr)[3], \
+ ((uint8_t *)addr)[4] << 8 | \
+ ((uint8_t *)addr)[5], \
+ ((uint8_t *)addr)[6] << 8 | \
+ ((uint8_t *)addr)[7], \
+ ((uint8_t *)addr)[8] << 8 | \
+ ((uint8_t *)addr)[9], \
+ ((uint8_t *)addr)[10] << 8 | \
+ ((uint8_t *)addr)[11], \
+ ((uint8_t *)addr)[12] << 8 | \
+ ((uint8_t *)addr)[13], \
+ ((uint8_t *)addr)[14] << 8 | \
+ ((uint8_t *)addr)[15]
total: 2 errors, 5 warnings, 1289 lines checked
next parent reply other threads:[~2019-12-11 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47c912c650adf1461634807af1ad086841e19187.1576089843.git.vladimir.medvedkin@intel.com>
2019-12-11 18:45 ` checkpatch [this message]
2019-12-12 8:55 ` [dpdk-test-report] |SUCCESS| pw63782 " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211184559.2E23F34EF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).