From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Subject: [dpdk-test-report] |WARNING| pw66595 [PATCH 05/13] app/test: introduce librte_security tests
Date: Thu, 12 Mar 2020 16:19:24 +0100 (CET) [thread overview]
Message-ID: <20200312151924.E6CCE1C02E@dpdk.org> (raw)
In-Reply-To: <20200312151654.7218-6-l.wojciechow@partner.samsung.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66595
_coding style issues_
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#311: FILE: app/test/test_security.c:129:
+#define TEST_ASSERT_MOCK_FUNCTION_CALL_RET(f_name, f_ret, exp_ret, \
+ ret_spec) do { \
+ TEST_ASSERT_EQUAL(exp_ret, f_ret, "Expecting " RTE_STR(f_name) \
+ " to return " ret_spec ", but it returned " ret_spec "
", \
+ exp_ret, f_ret); \
+} while (0)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 8)
#312: FILE: app/test/test_security.c:130:
+ ret_spec) do { \
+ TEST_ASSERT_EQUAL(exp_ret, f_ret, "Expecting " RTE_STR(f_name) \
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#324: FILE: app/test/test_security.c:142:
+#define TEST_ASSERT_MOCK_FUNCTION_CALL_NOT_NULL(f_name, f_ret) do { \
+ TEST_ASSERT_NOT_NULL(f_ret, "Expecting " RTE_STR(f_name) \
+ " to return not NULL
"); \
+} while (0)
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#403: FILE: app/test/test_security.c:221:
+static int
+mock_session_create(void *device,
+ struct rte_security_session_conf *conf,
+ struct rte_security_session *sess,
+ struct rte_mempool *mp) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#434: FILE: app/test/test_security.c:252:
+static int
+mock_session_destroy(void *device,
+ struct rte_security_session *sess) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#506: FILE: app/test/test_security.c:324:
+static int
+testsuite_setup(void) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#523: FILE: app/test/test_security.c:341:
+static void
+testsuite_teardown(void) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#537: FILE: app/test/test_security.c:355:
+static int
+ut_setup(void) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#560: FILE: app/test/test_security.c:378:
+static int
+destroy_session_with_check(void) {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#587: FILE: app/test/test_security.c:405:
+static void
+ut_teardown(void) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#745: FILE: app/test/test_security.c:563:
+ for (i = 0; i < SECURITY_TEST_MEMPOOL_SIZE; ++i) {
+ rte_mempool_put(ts_params->session_mpool, (void *)(tmp[i]));
+ }
WARNING:LONG_LINE: line over 90 characters
#827: FILE: app/test/test_security.c:645:
+ test_rte_security_session_create_inv_param_context_ops_fun),
total: 7 errors, 5 warnings, 699 lines checked
parent reply other threads:[~2020-03-12 15:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200312151654.7218-6-l.wojciechow@partner.samsung.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312151924.E6CCE1C02E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=l.wojciechow@partner.samsung.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).