From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78295 [PATCH 50/60] common/sfc_efx/base: support UDP tunnel operations for EF100
Date: Tue, 22 Sep 2020 10:59:12 +0200 (CEST) [thread overview]
Message-ID: <20200922085912.D7BF71DBC4@dpdk.org> (raw)
In-Reply-To: <1600764594-14752-51-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78295
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#169: FILE: drivers/common/sfc_efx/base/efx_mcdi.h:392:
+#define MCDI_IN_SET_WORD_NATIVE(_emr, _ofst, _value) \
+ MCDI_IN2((_emr), efx_word_t, _ofst)->ew_u16[0] = (_value)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#172: FILE: drivers/common/sfc_efx/base/efx_mcdi.h:395:
+#define MCDI_IN_SET_DWORD_NATIVE(_emr, _ofst, _value) \
+ MCDI_IN2((_emr), efx_dword_t, _ofst)->ed_u32[0] = (_value)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#377: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:72:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#414: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:109:
+ EFX_STATIC_ASSERT(sizeof (spec->evers_loc_host) ==
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#447: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:142:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#458: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:153:
+ return (rc);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#463: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:158:
+ __in efx_nic_t *enp,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#464: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:159:
+ __in efx_vnic_encap_rule_handle_t handle)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#467: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:162:
+ efx_mcdi_req_t req;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#468: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:163:
+ EFX_MCDI_DECLARE_BUF(payload,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#469: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:164:
+ MC_CMD_VNIC_ENCAP_RULE_REMOVE_IN_LEN,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#469: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:164:
+ MC_CMD_VNIC_ENCAP_RULE_REMOVE_IN_LEN,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#470: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:165:
+ MC_CMD_VNIC_ENCAP_RULE_REMOVE_OUT_LEN);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#470: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:165:
+ MC_CMD_VNIC_ENCAP_RULE_REMOVE_OUT_LEN);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#471: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:166:
+ efx_rc_t rc;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#473: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:168:
+ req.emr_cmd = MC_CMD_VNIC_ENCAP_RULE_REMOVE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#474: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:169:
+ req.emr_in_buf = payload;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#475: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:170:
+ req.emr_in_length = MC_CMD_VNIC_ENCAP_RULE_REMOVE_IN_LEN;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#476: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:171:
+ req.emr_out_buf = payload;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#477: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:172:
+ req.emr_out_length = MC_CMD_VNIC_ENCAP_RULE_REMOVE_OUT_LEN;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#479: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:174:
+ MCDI_IN_SET_DWORD(req, VNIC_ENCAP_RULE_REMOVE_IN_HANDLE, handle);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#481: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:176:
+ efx_mcdi_execute(enp, &req);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#483: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:178:
+ if (req.emr_rc != 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#483: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:178:
+ if (req.emr_rc != 0) {
+ rc = req.emr_rc;
ERROR:CODE_INDENT: code indent should use tabs where possible
#484: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:179:
+ rc = req.emr_rc;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#484: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:179:
+ rc = req.emr_rc;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#485: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:180:
+ goto fail1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#485: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:180:
+ goto fail1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#486: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:181:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#488: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:183:
+ if (req.emr_out_length_used != MC_CMD_VNIC_ENCAP_RULE_REMOVE_OUT_LEN) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#488: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:183:
+ if (req.emr_out_length_used != MC_CMD_VNIC_ENCAP_RULE_REMOVE_OUT_LEN) {
+ rc = EMSGSIZE;
ERROR:CODE_INDENT: code indent should use tabs where possible
#489: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:184:
+ rc = EMSGSIZE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#489: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:184:
+ rc = EMSGSIZE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#490: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:185:
+ goto fail2;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#490: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:185:
+ goto fail2;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#491: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:186:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#493: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:188:
+ return (0);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#496: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:191:
+ EFSYS_PROBE(fail2);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#499: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:194:
+ EFSYS_PROBE1(fail1, efx_rc_t, rc);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#501: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:196:
+ return (rc);$
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#501: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:196:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#509: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:204:
+ memset(spec, 0, sizeof (*spec));
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#522: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:217:
+ __inout efx_tunnel_udp_entry_t *etuep)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#527: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:222:
+ return (efx_mcdi_vnic_encap_rule_add(enp, &spec, &etuep->etue_handle));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#535: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:230:
+ return (efx_mcdi_vnic_encap_rule_remove(enp, etuep->etue_handle));
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#542: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:237:
+ efx_tunnel_cfg_t *etcp = &enp->en_tunnel_cfg;
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#557: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:252:
+ memcpy(&etc, etcp, sizeof (etc));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#557: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:252:
+ memcpy(&etc, etcp, sizeof (etc));
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#595: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:290:
+ for (i = 0, j = 0; i < etcp->etc_udp_entries_num; i++) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#596: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:291:
+ efx_tunnel_udp_entry_t *cur_entry = &etcp->etc_udp_entries[i];
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#608: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:303:
+ return (0);
total: 15 errors, 36 warnings, 495 lines checked
parent reply other threads:[~2020-09-22 8:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600764594-14752-51-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922085912.D7BF71DBC4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).