[dpdk-test-report] |WARNING| pw78709 [PATCH v3 32/60] common/sfc_efx/base: implement Rx control path for Riverhead

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78709 [PATCH v3 32/60] common/sfc_efx/base: implement Rx control path for Riverhead
Date: Thu, 24 Sep 2020 14:19:33 +0200 (CEST)	[thread overview]
Message-ID: <20200924121933.61F341DEF8@dpdk.org> (raw)
In-Reply-To: <1600949555-28043-33-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78709

_coding style issues_


WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#383: FILE: drivers/common/sfc_efx/base/rhead_impl.h:323:
+	__inout		unsigned int *pushedp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#449: FILE: drivers/common/sfc_efx/base/rhead_rx.c:23:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#453: FILE: drivers/common/sfc_efx/base/rhead_rx.c:27:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#490: FILE: drivers/common/sfc_efx/base/rhead_rx.c:64:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#494: FILE: drivers/common/sfc_efx/base/rhead_rx.c:68:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#508: FILE: drivers/common/sfc_efx/base/rhead_rx.c:82:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#512: FILE: drivers/common/sfc_efx/base/rhead_rx.c:86:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#529: FILE: drivers/common/sfc_efx/base/rhead_rx.c:103:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#533: FILE: drivers/common/sfc_efx/base/rhead_rx.c:107:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#549: FILE: drivers/common/sfc_efx/base/rhead_rx.c:123:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#553: FILE: drivers/common/sfc_efx/base/rhead_rx.c:127:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#569: FILE: drivers/common/sfc_efx/base/rhead_rx.c:143:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#573: FILE: drivers/common/sfc_efx/base/rhead_rx.c:147:
+	return (rc);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#586: FILE: drivers/common/sfc_efx/base/rhead_rx.c:160:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#601: FILE: drivers/common/sfc_efx/base/rhead_rx.c:175:
+	return (ENOTSUP);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#624: FILE: drivers/common/sfc_efx/base/rhead_rx.c:198:
+	__inout	unsigned int *pushedp)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#640: FILE: drivers/common/sfc_efx/base/rhead_rx.c:214:
+	if ((rc = efx_mcdi_fini_rxq(enp, erp->er_index)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#643: FILE: drivers/common/sfc_efx/base/rhead_rx.c:217:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#655: FILE: drivers/common/sfc_efx/base/rhead_rx.c:229:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#714: FILE: drivers/common/sfc_efx/base/rhead_rx.c:288:
+	if ((rc = efx_mcdi_init_rxq(enp, ndescs, eep, label, index,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#722: FILE: drivers/common/sfc_efx/base/rhead_rx.c:296:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#731: FILE: drivers/common/sfc_efx/base/rhead_rx.c:305:
+	return (rc);

total: 18 errors, 4 warnings, 589 lines checked

          parent reply	other threads:[~2020-09-24 12:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1600949555-28043-33-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924121933.61F341DEF8@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).