From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78728 [PATCH v3 44/60] common/sfc_efx/base: add function control window lookup API
Date: Thu, 24 Sep 2020 14:23:49 +0200 (CEST) [thread overview]
Message-ID: <20200924122349.849531E4C1@dpdk.org> (raw)
In-Reply-To: <1600949555-28043-45-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78728
_coding style issues_
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#213: FILE: drivers/common/sfc_efx/base/efx_impl.h:1576:
+ __inout size_t *offsetp);
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#213: FILE: drivers/common/sfc_efx/base/efx_impl.h:1576:
+ __inout size_t *offsetp);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#226: FILE: drivers/common/sfc_efx/base/efx_impl.h:1589:
+ __inout size_t *offsetp);
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#226: FILE: drivers/common/sfc_efx/base/efx_impl.h:1589:
+ __inout size_t *offsetp);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#238: FILE: drivers/common/sfc_efx/base/efx_impl.h:1601:
+ __inout size_t *pci_cap_offsetp,
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#238: FILE: drivers/common/sfc_efx/base/efx_impl.h:1601:
+ __inout size_t *pci_cap_offsetp,
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#240: FILE: drivers/common/sfc_efx/base/efx_impl.h:1603:
+ __out efsys_dma_addr_t *xilinx_tbl_offsetp);
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#255: FILE: drivers/common/sfc_efx/base/efx_impl.h:1618:
+ __out efsys_dma_addr_t *offsetp);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#292: FILE: drivers/common/sfc_efx/base/efx_nic.c:128:
+ return (rc);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#334: FILE: drivers/common/sfc_efx/base/efx_pci.c:15:
+ __inout size_t *offsetp)
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#334: FILE: drivers/common/sfc_efx/base/efx_pci.c:15:
+ __inout size_t *offsetp)
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#340: FILE: drivers/common/sfc_efx/base/efx_pci.c:21:
+ if (offsetp == NULL) {
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#345: FILE: drivers/common/sfc_efx/base/efx_pci.c:26:
+ if (*offsetp == 0) {
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#346: FILE: drivers/common/sfc_efx/base/efx_pci.c:27:
+ *offsetp = ESE_GZ_PCI_BASE_CONFIG_SPACE_SIZE;
WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#348: FILE: drivers/common/sfc_efx/base/efx_pci.c:29:
+ EFSYS_PCI_CONFIG_READD(espcp, *offsetp +
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#348: FILE: drivers/common/sfc_efx/base/efx_pci.c:29:
+ EFSYS_PCI_CONFIG_READD(espcp, *offsetp +
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#360: FILE: drivers/common/sfc_efx/base/efx_pci.c:41:
+ *offsetp = next;
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#374: FILE: drivers/common/sfc_efx/base/efx_pci.c:55:
+ return (rc);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#381: FILE: drivers/common/sfc_efx/base/efx_pci.c:62:
+ __inout size_t *offsetp)
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#381: FILE: drivers/common/sfc_efx/base/efx_pci.c:62:
+ __inout size_t *offsetp)
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#387: FILE: drivers/common/sfc_efx/base/efx_pci.c:68:
+ if (offsetp == NULL) {
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#392: FILE: drivers/common/sfc_efx/base/efx_pci.c:73:
+ position = *offsetp;
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#399: FILE: drivers/common/sfc_efx/base/efx_pci.c:80:
+ break;
+ else
WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#403: FILE: drivers/common/sfc_efx/base/efx_pci.c:84:
+ EFSYS_PCI_CONFIG_READD(espcp, position +
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#413: FILE: drivers/common/sfc_efx/base/efx_pci.c:94:
+ *offsetp = position;
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#432: FILE: drivers/common/sfc_efx/base/efx_pci.c:113:
+ return (rc);
WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#438: FILE: drivers/common/sfc_efx/base/efx_pci.c:119:
+ __inout size_t *pci_cap_offsetp,
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#438: FILE: drivers/common/sfc_efx/base/efx_pci.c:119:
+ __inout size_t *pci_cap_offsetp,
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#440: FILE: drivers/common/sfc_efx/base/efx_pci.c:121:
+ __out efsys_dma_addr_t *xilinx_tbl_offsetp)
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#445: FILE: drivers/common/sfc_efx/base/efx_pci.c:126:
+ if (pci_cap_offsetp == NULL) {
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#450: FILE: drivers/common/sfc_efx/base/efx_pci.c:131:
+ cap_offset = *pci_cap_offsetp;
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#461: FILE: drivers/common/sfc_efx/base/efx_pci.c:142:
+ break;
+ else
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#475: FILE: drivers/common/sfc_efx/base/efx_pci.c:156:
+ *xilinx_tbl_offsetp = tbl_offset;
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#476: FILE: drivers/common/sfc_efx/base/efx_pci.c:157:
+ *pci_cap_offsetp = cap_offset;
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#478: FILE: drivers/common/sfc_efx/base/efx_pci.c:159:
+ break;
+ } else {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#499: FILE: drivers/common/sfc_efx/base/efx_pci.c:180:
+ return (rc);
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#507: FILE: drivers/common/sfc_efx/base/efx_pci.c:188:
+ __out efsys_dma_addr_t *offsetp)
WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#521: FILE: drivers/common/sfc_efx/base/efx_pci.c:202:
+ EFSYS_PCI_CONFIG_READD(espcp, cap_offset +
WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#535: FILE: drivers/common/sfc_efx/base/efx_pci.c:216:
+ EFSYS_PCI_CONFIG_READD(espcp, vsec_offset +
WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#562: FILE: drivers/common/sfc_efx/base/efx_pci.c:243:
+ EFSYS_PCI_CONFIG_READD(espcp, vsec_offset +
WARNING:TYPO_SPELLING: 'READD' may be misspelled - perhaps 'RE-ADD'?
#574: FILE: drivers/common/sfc_efx/base/efx_pci.c:255:
+ EFSYS_PCI_CONFIG_READD(espcp, vsec_offset +
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#598: FILE: drivers/common/sfc_efx/base/efx_pci.c:279:
+ *offsetp = offset;
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#601: FILE: drivers/common/sfc_efx/base/efx_pci.c:282:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#618: FILE: drivers/common/sfc_efx/base/efx_pci.c:299:
+ return (rc);
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#717: FILE: drivers/common/sfc_efx/base/rhead_pci.c:46:
+ break;
+ } else {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#729: FILE: drivers/common/sfc_efx/base/rhead_pci.c:58:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#736: FILE: drivers/common/sfc_efx/base/rhead_pci.c:65:
+ return (rc);
total: 8 errors, 39 warnings, 587 lines checked
parent reply other threads:[~2020-09-24 12:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600949555-28043-45-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924122349.849531E4C1@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).