From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw80533 [PATCH 31/36] net/sfc: support per-queue Rx prefix for EF100
Date: Tue, 13 Oct 2020 15:55:57 +0200 (CEST) [thread overview]
Message-ID: <20201013135557.59FDC1DBDD@dpdk.org> (raw)
In-Reply-To: <1602596753-32282-32-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/80533
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#184: FILE: drivers/net/sfc/sfc_ef100_rx.c:732:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#193: FILE: drivers/net/sfc/sfc_ef100_rx.c:741:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#253: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:664:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#257: FILE: drivers/net/sfc/sfc_ef10_essb_rx.c:668:
+ return ENOTSUP;
WARNING:TYPO_SPELLING: 'accesssors' may be misspelled - perhaps 'accessors'?
#271: FILE: drivers/net/sfc/sfc_ef10_rx.c:227:
+ * Below Rx pseudo-header (aka Rx prefix) accesssors rely on the
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#277: FILE: drivers/net/sfc/sfc_ef10_rx.c:233:
+ [EFX_RX_PREFIX_FIELD_RSS_HASH] =
+ { 0, sizeof(uint32_t) * CHAR_BIT, B_FALSE },
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#279: FILE: drivers/net/sfc/sfc_ef10_rx.c:235:
+ [EFX_RX_PREFIX_FIELD_LENGTH] =
+ { 8 * CHAR_BIT, sizeof(uint16_t) * CHAR_BIT, B_FALSE },
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#301: FILE: drivers/net/sfc/sfc_ef10_rx.c:726:
+ return ENOTSUP;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#329: FILE: drivers/net/sfc/sfc_rx.c:545:
+ return ENOTSUP;
total: 2 errors, 7 warnings, 0 checks, 221 lines checked
parent reply other threads:[~2020-10-13 13:56 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1602596753-32282-32-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013135557.59FDC1DBDD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).