[dpdk-test-report] |WARNING| pw80626 [PATCH v3 04/56] net/txgbe: add error types and registers

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw80626 [PATCH v3 04/56] net/txgbe: add error types and registers
Date: Wed, 14 Oct 2020 07:57:36 +0200 (CEST)	[thread overview]
Message-ID: <20201014055736.2D0F71DBCB@dpdk.org> (raw)
In-Reply-To: <20201014055517.1214386-5-jiawenwu@trustnetic.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/80626

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#107: FILE: drivers/net/txgbe/base/txgbe_regs.h:35:
+#define ROUND_UP(x, y)          (((x) + (y) - 1) / (y) * (y))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#108: FILE: drivers/net/txgbe/base/txgbe_regs.h:36:
+#define ROUND_DOWN(x, y)        ((x) / (y) * (y))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#109: FILE: drivers/net/txgbe/base/txgbe_regs.h:37:
+#define ROUND_OVER(x, maxbits, unitbits) \
+	((x) >= 1 << (maxbits) ? 0 : (x) >> (unitbits))

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_LMS_10Gs>
#127: FILE: drivers/net/txgbe/base/txgbe_regs.h:55:
+#define   TXGBE_AUTOC_LMS_10Gs            LS64(3, 13, 0x7)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_PMA_PMD_MASK>
#154: FILE: drivers/net/txgbe/base/txgbe_regs.h:82:
+#define   TXGBE_AUTOC_10Gs_PMA_PMD_MASK   MS64(48, 0x3)  /* serial */

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_KR>
#155: FILE: drivers/net/txgbe/base/txgbe_regs.h:83:
+#define   TXGBE_AUTOC_10Gs_KR             LS64(0, 48, 0x3)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_XFI>
#156: FILE: drivers/net/txgbe/base/txgbe_regs.h:84:
+#define   TXGBE_AUTOC_10Gs_XFI            LS64(1, 48, 0x3)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_SFI>
#157: FILE: drivers/net/txgbe/base/txgbe_regs.h:85:
+#define   TXGBE_AUTOC_10Gs_SFI            LS64(2, 48, 0x3)

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#378: FILE: drivers/net/txgbe/base/txgbe_regs.h:306:
+#define   TXGBE_LEDCTL_ORD(s)            MS(((s)+16), 0x1)
                                                 ^

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#899: FILE: drivers/net/txgbe/base/txgbe_regs.h:827:
+#define   TXGBE_FCRSSTBL_QUE(v)    LS(v, 0, 0x7F)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACRX1024toMAXL>
#1156: FILE: drivers/net/txgbe/base/txgbe_regs.h:1084:
+#define TXGBE_MACRX1024toMAXL        0x001968

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACRX1024toMAXH>
#1157: FILE: drivers/net/txgbe/base/txgbe_regs.h:1085:
+#define TXGBE_MACRX1024toMAXH        0x00196C

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACTX1024toMAXL>
#1168: FILE: drivers/net/txgbe/base/txgbe_regs.h:1096:
+#define TXGBE_MACTX1024toMAXL        0x00185C

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACTX1024toMAXH>
#1169: FILE: drivers/net/txgbe/base/txgbe_regs.h:1097:
+#define TXGBE_MACTX1024toMAXH        0x001860

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1329: FILE: drivers/net/txgbe/base/txgbe_regs.h:1257:
+#define   TXGBE_VFPBWRAP_WRAP(r, tc)    ((0x7 << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1330: FILE: drivers/net/txgbe/base/txgbe_regs.h:1258:
+#define   TXGBE_VFPBWRAP_EMPT(r, tc)    ((0x8 << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1530: FILE: drivers/net/txgbe/base/txgbe_regs.h:1458:
+#define   TXGBE_PBRXSTAT_WRAP(tc, r)    ((7u << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1531: FILE: drivers/net/txgbe/base/txgbe_regs.h:1459:
+#define   TXGBE_PBRXSTAT_EMPT(tc, r)    ((8u << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1544: FILE: drivers/net/txgbe/base/txgbe_regs.h:1472:
+#define   TXGBE_PBTXSTAT_EMPT(tc, r)    ((1 << (tc) & (r)) >> (tc))

WARNING:TYPO_SPELLING: 'sting' may be misspelled - perhaps 'string'?
#1768: FILE: drivers/net/txgbe/base/txgbe_regs.h:1696:
+#define NVM_VER_SIZE		32    /* version sting size */

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#1913: FILE: drivers/net/txgbe/base/txgbe_regs.h:1841:
+#define rd32w(hw, reg, mask, slice) do { \
+	rd32((hw), reg); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#1913: FILE: drivers/net/txgbe/base/txgbe_regs.h:1841:
+#define rd32w(hw, reg, mask, slice) do { \
+	rd32((hw), reg); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#1913: FILE: drivers/net/txgbe/base/txgbe_regs.h:1841:
+#define rd32w(hw, reg, mask, slice) do { \
+	rd32((hw), reg); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#1918: FILE: drivers/net/txgbe/base/txgbe_regs.h:1846:
+#define wr32w(hw, reg, val, mask, slice) do { \
+	wr32((hw), reg, val); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#1918: FILE: drivers/net/txgbe/base/txgbe_regs.h:1846:
+#define wr32w(hw, reg, val, mask, slice) do { \
+	wr32((hw), reg, val); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#1918: FILE: drivers/net/txgbe/base/txgbe_regs.h:1846:
+#define wr32w(hw, reg, val, mask, slice) do { \
+	wr32((hw), reg, val); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#2050: FILE: drivers/net/txgbe/base/txgbe_status.h:85:
+#define TXGBE_ERR_MASTER_REQUESTS_PENDING	-(TERR_BASE + 12)

total: 0 errors, 3 warnings, 24 checks, 2009 lines checked

          parent reply	other threads:[~2020-10-14  5:57 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20201014055517.1214386-5-jiawenwu@trustnetic.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201014055736.2D0F71DBCB@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).