From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jingjing Wu <jingjing.wu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw85509 [PATCH v1 2/2] net/iavf: introduce iavf driver on vfio-user client
Date: Sat, 19 Dec 2020 15:50:42 +0100 (CET) [thread overview]
Message-ID: <20201219145042.8EFCDCB85@dpdk.org> (raw)
In-Reply-To: <20201219143816.64174-3-jingjing.wu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85509
_coding style issues_
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#191: FILE: drivers/net/iavf/iavf_client_ethdev.c:27:
+static const char *valid_args[] = {
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#297: FILE: drivers/net/iavf/iavf_client_ethdev.c:133:
+ eth_dev->data->mac_addrs = rte_zmalloc(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#309: FILE: drivers/net/iavf/iavf_client_ethdev.c:145:
+ if (!rte_is_valid_assigned_ether_addr(
WARNING:BRACES: braces {} are not necessary for single statement blocks
#416: FILE: drivers/net/iavf/iavf_client_ethdev.c:252:
+ if (ret) {
+ goto err;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#421: FILE: drivers/net/iavf/iavf_client_ethdev.c:257:
+ if (ret) {
+ goto err;
+ }
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#550: FILE: drivers/net/iavf/iavf_rxtx.c:604:
+ rxq->qrx_tail = client_vfio_user_get_bar_addr(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#566: FILE: drivers/net/iavf/iavf_rxtx.c:721:
+ txq->qtx_tail = client_vfio_user_get_bar_addr(
total: 0 errors, 3 warnings, 4 checks, 452 lines checked
parent reply other threads:[~2020-12-19 14:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201219143816.64174-3-jingjing.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219145042.8EFCDCB85@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).