From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw101135 [kmods PATCH] windows/netuio: add interrupt support
Date: Tue, 12 Oct 2021 03:12:43 +0200 (CEST) [thread overview]
Message-ID: <20211012011243.BA8ED120E00@dpdk.org> (raw)
In-Reply-To: <20211012011107.431188-1-dmitry.kozliuk@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/101135
_coding style issues_
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#166: FILE: windows/netuio/netuio_dev.c:175:
+ WDFINTERRUPT* intrs;
ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: windows/netuio/netuio_dev.c:314:
+ goto end_of_loop;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#240: FILE: windows/netuio/netuio_dev.c:314:
+ goto end_of_loop;$
ERROR:SPACING: spaces required around that ':' (ctx:VxE)
#248: FILE: windows/netuio/netuio_dev.c:343:
+end_of_loop:
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: windows/netuio/netuio_dev.c:345:
+ status = netuio_intr_alloc(Device, Resources, ResourcesTranslated);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: windows/netuio/netuio_dev.h:29:
+ WDFQUEUE queue; /**< Queue of requests for this interrupt. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#285: FILE: windows/netuio/netuio_dev.h:44:
+ BOOLEAN intr_enabled; /**< Whether interrupt delivery is enabled. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: windows/netuio/netuio_dev.h:45:
+ WDFINTERRUPT *intr; /**< Interrupt objects indexed by vector. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#287: FILE: windows/netuio/netuio_dev.h:46:
+ size_t intr_n; /**< Number of interrupt objects. */$
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#304: FILE: windows/netuio/netuio_interface.h:58:
+#define IOCTL_NETUIO_INTR_CONTROL CTL_CODE(FILE_DEVICE_NETWORK, 53, METHOD_BUFFERED, FILE_ANY_ACCESS)
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#321: FILE: windows/netuio/netuio_interface.h:101:
+ UINT32 enable; /**< 1 to enable interrupts, 0 to disable */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#325: FILE: windows/netuio/netuio_interface.h:105:
+ UINT32 vector; /**< Vector of the interrupt to wait for. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#406: FILE: windows/netuio/netuio_queue.c:287:
+ PVOID input_buf = NULL, output_buf = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#407: FILE: windows/netuio/netuio_queue.c:288:
+ size_t input_buf_size, output_buf_size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#408: FILE: windows/netuio/netuio_queue.c:289:
+ size_t bytes_returned = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#409: FILE: windows/netuio/netuio_queue.c:290:
+ NTSTATUS status;$
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#429: FILE: windows/netuio/netuio_queue.c:346:
+/*
+Routine Description:
total: 3 errors, 14 warnings, 321 lines checked
parent reply other threads:[~2021-10-12 1:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20211012011107.431188-1-dmitry.kozliuk@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012011243.BA8ED120E00@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).