[dpdk-test-report] |WARNING| pw103239 [PATCH] app/testpmd: add GPU memory option in iofwd engine

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/103239

_coding style issues_


WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#225: FILE: app/test-pmd/parameters.c:1550:
+		if (mbuf_mem_types[idx] == MBUF_MEM_GPU && strcmp(cur_fwd_eng->fwd_mode_name, "io") != 0) {

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#256: FILE: app/test-pmd/testpmd.c:556:
+int gpu_id = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#268: FILE: app/test-pmd/testpmd.c:1121:
+			int gpu_id, uintptr_t * mp_addr)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#309: FILE: app/test-pmd/testpmd.c:1162:
+	if (gpu_mem.buf_ptr == NULL) {
+		rte_exit(EXIT_FAILURE, "Could not allocate GPU device memory
");
+	}

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#313: FILE: app/test-pmd/testpmd.c:1166:
+	ret = rte_extmem_register(gpu_mem.buf_ptr, gpu_mem.buf_len, NULL, gpu_mem.buf_iova, gpu_page_size);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#314: FILE: app/test-pmd/testpmd.c:1167:
+	if (ret) {
+		rte_exit(EXIT_FAILURE, "Unable to register addr 0x%p, ret %d
", gpu_mem.buf_ptr, ret);
+	}

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#315: FILE: app/test-pmd/testpmd.c:1168:
+		rte_exit(EXIT_FAILURE, "Unable to register addr 0x%p, ret %d
", gpu_mem.buf_ptr, ret);

WARNING:LONG_LINE: line length of 128 exceeds 100 columns
#330: FILE: app/test-pmd/testpmd.c:1183:
+	rte_mp = rte_pktmbuf_pool_create_extbuf(pool_name, nb_mbuf, mb_mempool_cache, 0, mbuf_seg_size, socket_id, &gpu_mem, 1);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#331: FILE: app/test-pmd/testpmd.c:1184:
+	if (rte_mp == NULL) {
+		rte_exit(EXIT_FAILURE, "Creation of GPU mempool <%s> failed
", pool_name);
+	}

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#355: FILE: app/test-pmd/testpmd.c:1789:
 			for (j = 0; j < mbuf_data_size_n; j++)
+			{

ERROR:SPACING: space required before the open parenthesis '('
#362: FILE: app/test-pmd/testpmd.c:1792:
+					if(rte_gpu_count_avail() == 0)

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#367: FILE: app/test-pmd/testpmd.c:1797:
+											 nb_mbuf_per_pool,

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#368: FILE: app/test-pmd/testpmd.c:1798:
+											 socket_ids[i], j, gpu_id,

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#369: FILE: app/test-pmd/testpmd.c:1799:
+											 &(mempools_ext_ptr[j]));

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#380: FILE: app/test-pmd/testpmd.c:1810:
 		for (i = 0; i < mbuf_data_size_n; i++)
+		{

WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#389: FILE: app/test-pmd/testpmd.c:1814:
+												   nb_mbuf_per_pool,

WARNING:LONG_LINE: line length of 144 exceeds 100 columns
#390: FILE: app/test-pmd/testpmd.c:1815:
+												   socket_num == UMA_NO_CONFIG ? 0 : socket_num,

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#391: FILE: app/test-pmd/testpmd.c:1816:
+												   i, gpu_id,

WARNING:LONG_LINE: line length of 123 exceeds 100 columns
#392: FILE: app/test-pmd/testpmd.c:1817:
+												   &(mempools_ext_ptr[i]));

WARNING:BRACES: braces {} are not necessary for single statement blocks
#411: FILE: app/test-pmd/testpmd.c:3530:
+			if (mbuf_mem_types[i] == MBUF_MEM_GPU) {
+				rte_gpu_free(gpu_id, (void*)mempools_ext_ptr[i]);
+			}

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#412: FILE: app/test-pmd/testpmd.c:3531:
+				rte_gpu_free(gpu_id, (void*)mempools_ext_ptr[i]);

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: eagostini <eagostini@nvidia.com>' != 'Signed-off-by: Elena Agostini <eagostini@nvidia.com>'

total: 6 errors, 16 warnings, 306 lines checked