automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Yanling Song <songyl@ramaxel.com>
Subject: |WARNING| pw105246 [PATCH v1 04/25] net/spnic: introduce event queue
Date: Sat, 18 Dec 2021 03:54:52 +0100 (CET)	[thread overview]
Message-ID: <20211218025452.CD966123543@dpdk.org> (raw)
In-Reply-To: <cff4c053206f3ddbc729cb59286e05bbd4a28aec.1639636621.git.songyl@ramaxel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105246

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#179: FILE: drivers/net/spnic/base/spnic_eqs.c:86:
+#define EQ_CONS_IDX(eq)		((eq)->cons_idx | \
+				((u32)(eq)->wrapped << EQ_WRAPPED_SHIFT))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#181: FILE: drivers/net/spnic/base/spnic_eqs.c:88:
+#define GET_EQ_NUM_PAGES(eq, size)	\
+		((u16)(RTE_ALIGN((u32)((eq)->eq_len * (eq)->elem_size), \
+		(size)) / (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#181: FILE: drivers/net/spnic/base/spnic_eqs.c:88:
+#define GET_EQ_NUM_PAGES(eq, size)	\
+		((u16)(RTE_ALIGN((u32)((eq)->eq_len * (eq)->elem_size), \
+		(size)) / (size)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#187: FILE: drivers/net/spnic/base/spnic_eqs.c:94:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(u32)(((idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#187: FILE: drivers/net/spnic/base/spnic_eqs.c:94:
+#define GET_EQ_ELEMENT(eq, idx)		\
+		(((u8 *)(eq)->virt_addr[(idx) / (eq)->num_elem_in_pg]) + \
+		(u32)(((idx) & ((eq)->num_elem_in_pg - 1)) * (eq)->elem_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#194: FILE: drivers/net/spnic/base/spnic_eqs.c:101:
+#define GET_CURR_AEQ_ELEM(eq)		GET_AEQ_ELEM((eq), (eq)->cons_idx)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eq' - possible side-effects?
#211: FILE: drivers/net/spnic/base/spnic_eqs.c:118:
+#define aeq_to_aeqs(eq) \
+		container_of((eq) - (eq)->q_id, struct spnic_aeqs, aeq[0])

total: 0 errors, 0 warnings, 7 checks, 874 lines checked

           reply	other threads:[~2021-12-18  2:54 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <cff4c053206f3ddbc729cb59286e05bbd4a28aec.1639636621.git.songyl@ramaxel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211218025452.CD966123543@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=songyl@ramaxel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).