From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Josh Soref <jsoref@gmail.com>
Subject: |WARNING| pw105747 [PATCH 1/1] fix spelling in code
Date: Wed, 12 Jan 2022 08:29:13 +0100 (CET) [thread overview]
Message-ID: <20220112072913.42B71121D83@dpdk.org> (raw)
In-Reply-To: <20220112072808.59713-2-jsoref@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105747
_coding style issues_
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#294: FILE: app/test/test_link_bonding.c:2029:
+test_roundrobin_verify_polling_slave_link_status_change(void)
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#303: FILE: app/test/test_link_bonding.c:5121:
+ TEST_CASE(test_roundrobin_verify_polling_slave_link_status_change),
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#339: FILE: app/test/test_link_bonding_mode4.c:261:
+ RTE_VERIFY(slave->lacp_partner_state == 0);
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#348: FILE: app/test/test_link_bonding_mode4.c:291:
+ slave->lacp_partner_state = 0;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#364: FILE: app/test/test_link_bonding_mode4.c:510:
+ slave->lacp_partner_state = lacp->actor.state;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#381: FILE: app/test/test_link_bonding_mode4.c:583:
+ return slave->lacp_partner_state == expected_state;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#390: FILE: app/test/test_link_bonding_mode4.c:1137:
+ "slave %u unexpectedly transmitted %u packets",
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#408: FILE: app/test/test_link_bonding_mode4.c:1356:
+ TEST_ASSERT(slave->lacp_partner_state & STATE_EXPIRED,
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#576: FILE: drivers/common/cnxk/roc_mbox.h:1742:
+ TIM_AF_ENA_DONTFREE_NSET_PERIODIC = -816,
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#589: FILE: drivers/common/cnxk/roc_tim.c:76:
+ case TIM_AF_ENA_DONTFREE_NSET_PERIODIC:
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#782: FILE: drivers/common/octeontx2/otx2_mbox.h:1628:
+ TIM_AF_ENA_DONTFREE_NSET_PERIODIC = -816,
ERROR:CODE_INDENT: code indent should use tabs where possible
#795: FILE: drivers/common/sfc_efx/base/ef10_signed_image_layout.h:38:
+ * including the certificates and signature */$
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#795: FILE: drivers/common/sfc_efx/base/ef10_signed_image_layout.h:38:
+ * including the certificates and signature */
WARNING:TYPO_SPELLING: 'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'?
#834: FILE: drivers/common/sfc_efx/base/efx_types.h:6:
+ * Acknowledgement to Fen Systems Ltd.
WARNING:TYPO_SPELLING: 'FLE' may be misspelled - perhaps 'FILE'?
#1047: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:451:
+ * So while retrieving we can go back 1 FLE from the FD -ADDR
WARNING:TYPO_SPELLING: 'FLE' may be misspelled - perhaps 'FILE'?
#1074: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:743:
+ * So while retrieving we can go back 1 FLE from the FD -ADDR
WARNING:TYPO_SPELLING: 'FLE' may be misspelled - perhaps 'FILE'?
#1083: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1012:
+ * So while retrieving we can go back 1 FLE from the FD -ADDR
WARNING:TYPO_SPELLING: 'FLE' may be misspelled - perhaps 'FILE'?
#1092: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1265:
+ * So while retrieving we can go back 1 FLE from the FD -ADDR
WARNING:TYPO_SPELLING: 'FLE' may be misspelled - perhaps 'FILE'?
#1127: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1571:
+ * So while retrieving we can go back 1 FLE from the FD -ADDR
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#1269: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:148:
+ otx2_err("Unable to allocate new TIM ring.");
WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#1278: FILE: drivers/event/octeontx2/otx2_tim_evdev.c:192:
+ case TIM_AF_ENA_DONTFREE_NSET_PERIODIC:
CHECK:SPACING: No space is necessary after a cast
#1356: FILE: drivers/net/bnx2x/bnx2x.c:4044:
+ (uint32_t) (attn & HW_INTERRUPT_ASSERT_SET_2));
CHECK:SPACING: No space is necessary after a cast
#1377: FILE: drivers/net/bnx2x/bnx2x.c:4074:
+ (uint32_t) (attn & HW_INTERRUPT_ASSERT_SET_1));
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1407: FILE: drivers/net/bnx2x/bnx2x.h:1712:
+#define HW_INTERRUPT_ASSERT_SET_0 \
(AEU_INPUTS_ATTN_BITS_TSDM_HW_INTERRUPT | \
AEU_INPUTS_ATTN_BITS_TCM_HW_INTERRUPT | \
AEU_INPUTS_ATTN_BITS_TSEMI_HW_INTERRUPT | \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1416: FILE: drivers/net/bnx2x/bnx2x.h:1725:
+#define HW_INTERRUPT_ASSERT_SET_1 \
(AEU_INPUTS_ATTN_BITS_QM_HW_INTERRUPT | \
AEU_INPUTS_ATTN_BITS_TIMERS_HW_INTERRUPT | \
AEU_INPUTS_ATTN_BITS_XSDM_HW_INTERRUPT | \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1425: FILE: drivers/net/bnx2x/bnx2x.h:1753:
+#define HW_INTERRUPT_ASSERT_SET_2 \
(AEU_INPUTS_ATTN_BITS_CSEMI_HW_INTERRUPT | \
AEU_INPUTS_ATTN_BITS_CDU_HW_INTERRUPT | \
AEU_INPUTS_ATTN_BITS_DMAE_HW_INTERRUPT | \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1456: FILE: drivers/net/bnx2x/bnx2x_stats.c:649:
+ ADD_STAT64(stats_rx.rx_grxpf, rx_stat_xoffsetateentered);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1465: FILE: drivers/net/bnx2x/bnx2x_stats.c:732:
+ UPDATE_EXTEND_STAT(rx_stat_xoffsetateentered);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1479: FILE: drivers/net/bnx2x/bnx2x_stats.h:108:
+ uint32_t rx_stat_xoffsetateentered_hi;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1480: FILE: drivers/net/bnx2x/bnx2x_stats.h:109:
+ uint32_t rx_stat_xoffsetateentered_lo;$
WARNING:LONG_LINE_COMMENT: line length of 135 exceeds 100 columns
#1557: FILE: drivers/net/bnx2x/ecore_hsi.h:2757:
+ #define PF_ALLOCATION_MSIX_VECTORS_MASK 0x000000ff /* real value, as PCI config space can show only maximum of 64 vectors */
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2037: FILE: drivers/net/dpaa2/dpaa2_flow.c:1344:
+dpaa2_configure_flow_ip_discrimination(
WARNING:TYPO_SPELLING: 'consective' may be misspelled - perhaps 'consecutive'?
#2175: FILE: drivers/net/enic/base/vnic_devcmd.h:594:
+ * Set cq array base and size in a list of consective wqs and
WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#2175: FILE: drivers/net/enic/base/vnic_devcmd.h:594:
+ * Set cq array base and size in a list of consective wqs and
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev' may be better as '(dev)' to avoid precedence issues
#3269: FILE: drivers/net/ixgbe/ixgbe_bypass_defines.h:109:
+#define IXGBE_DEV_TO_ADAPTER(dev) \
((struct ixgbe_adapter *)(dev->data->dev_private))
WARNING:TYPO_SPELLING: 'incase' may be misspelled - perhaps 'in case'?
#3974: FILE: drivers/net/qede/base/ecore_sriov.c:1037:
+ * cleanness and ease of debugging incase a VF attempts to
total: 4 errors, 28 warnings, 3724 lines checked
next parent reply other threads:[~2022-01-12 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220112072808.59713-2-jsoref@gmail.com>
2022-01-12 7:29 ` checkpatch [this message]
2022-01-12 9:19 ` |SUCCESS| " 0-day Robot
2022-01-12 10:32 |WARNING| pw105747 [PATCH] [1/1] " dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112072913.42B71121D83@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jsoref@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).