From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Akhil Goyal <gakhil@marvell.com>
Subject: |WARNING| pw106145 [PATCH v2 2/4] net/cnxk: support IP reassembly
Date: Thu, 20 Jan 2022 17:55:00 +0100 (CET) [thread overview]
Message-ID: <20220120165500.B9FAC12091F@dpdk.org> (raw)
In-Reply-To: <20220120165310.4165567-3-gakhil@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106145
_coding style issues_
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3411: FILE: drivers/net/cnxk/cn10k_ethdev_sec.c:254:
+ if (rte_eth_ip_reass_dynfield_register(
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#4003: FILE: drivers/net/cnxk/cn10k_rx.h:540:
+ /* Clear checksum flags and update security flag
+ */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 20)
#4122: FILE: drivers/net/cnxk/cn10k_rx.h:782:
+ if ((!(flag & NIX_RX_SEC_REASS_F) || !(w1 & BIT(11))) &&
[...]
+ ol_flags |= nix_rx_olflags_get(lookup_mem, w1);
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#4243: FILE: drivers/net/cnxk/cn10k_rx.h:1623:
+#define NIX_RX_FASTPATH_MODES_192_207 \
+ R(reas_sec, R_REAS_F | R_SEC_F) \
+ R(reas_sec_rss, R_REAS_F | R_SEC_F | RSS_F) \
+ R(reas_sec_ptype, R_REAS_F | R_SEC_F | PTYPE_F) \
+ R(reas_sec_ptype_rss, R_REAS_F | R_SEC_F | PTYPE_F | RSS_F) \
+ R(reas_sec_cksum, R_REAS_F | R_SEC_F | CKSUM_F) \
+ R(reas_sec_cksum_rss, R_REAS_F | R_SEC_F | CKSUM_F | RSS_F) \
+ R(reas_sec_cksum_ptype, R_REAS_F | R_SEC_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_cksum_ptype_rss, R_REAS_F | R_SEC_F | CKSUM_F | PTYPE_F | RSS_F) \
+ R(reas_sec_mark, R_REAS_F | R_SEC_F | MARK_F) \
+ R(reas_sec_mark_rss, R_REAS_F | R_SEC_F | MARK_F | RSS_F) \
+ R(reas_sec_mark_ptype, R_REAS_F | R_SEC_F | MARK_F | PTYPE_F) \
+ R(reas_sec_mark_ptype_rss, R_REAS_F | R_SEC_F | MARK_F | PTYPE_F | RSS_F) \
+ R(reas_sec_mark_cksum, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F) \
+ R(reas_sec_mark_cksum_rss, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | RSS_F) \
+ R(reas_sec_mark_cksum_ptype, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_mark_cksum_ptype_rss, \
+ R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#4262: FILE: drivers/net/cnxk/cn10k_rx.h:1642:
+#define NIX_RX_FASTPATH_MODES_208_223 \
+ R(reas_sec_ts, R_REAS_F | R_SEC_F | TS_F) \
+ R(reas_sec_ts_rss, R_REAS_F | R_SEC_F | TS_F | RSS_F) \
+ R(reas_sec_ts_ptype, R_REAS_F | R_SEC_F | TS_F | PTYPE_F) \
+ R(reas_sec_ts_ptype_rss, R_REAS_F | R_SEC_F | TS_F | PTYPE_F | RSS_F) \
+ R(reas_sec_ts_cksum, R_REAS_F | R_SEC_F | TS_F | CKSUM_F) \
+ R(reas_sec_ts_cksum_rss, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | RSS_F) \
+ R(reas_sec_ts_cksum_ptype, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_ts_cksum_ptype_rss, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | PTYPE_F | RSS_F) \
+ R(reas_sec_ts_mark, R_REAS_F | R_SEC_F | TS_F | MARK_F) \
+ R(reas_sec_ts_mark_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | RSS_F) \
+ R(reas_sec_ts_mark_ptype, R_REAS_F | R_SEC_F | TS_F | MARK_F | PTYPE_F) \
+ R(reas_sec_ts_mark_ptype_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | PTYPE_F | RSS_F) \
+ R(reas_sec_ts_mark_cksum, R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F) \
+ R(reas_sec_ts_mark_cksum_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | RSS_F) \
+ R(reas_sec_ts_mark_cksum_ptype, \
+ R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_ts_mark_cksum_ptype_rss, \
+ R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#4282: FILE: drivers/net/cnxk/cn10k_rx.h:1662:
+#define NIX_RX_FASTPATH_MODES_224_239 \
+ R(reas_sec_vlan, R_REAS_F | R_SEC_F | RX_VLAN_F) \
+ R(reas_sec_vlan_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | RSS_F) \
+ R(reas_sec_vlan_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | PTYPE_F) \
+ R(reas_sec_vlan_ptype_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | PTYPE_F | RSS_F) \
+ R(reas_sec_vlan_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F) \
+ R(reas_sec_vlan_cksum_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | RSS_F) \
+ R(reas_sec_vlan_cksum_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_vlan_cksum_ptype_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F) \
+ R(reas_sec_vlan_mark, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F) \
+ R(reas_sec_vlan_mark_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | RSS_F) \
+ R(reas_sec_vlan_mark_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F) \
+ R(reas_sec_vlan_mark_ptype_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F | RSS_F) \
+ R(reas_sec_vlan_mark_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F) \
+ R(reas_sec_vlan_mark_cksum_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | RSS_F) \
+ R(reas_sec_vlan_mark_cksum_ptype, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_vlan_mark_cksum_ptype_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#4305: FILE: drivers/net/cnxk/cn10k_rx.h:1685:
+#define NIX_RX_FASTPATH_MODES_240_255 \
+ R(reas_sec_vlan_ts, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F) \
+ R(reas_sec_vlan_ts_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | RSS_F) \
+ R(reas_sec_vlan_ts_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F) \
+ R(reas_sec_vlan_ts_ptype_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F | RSS_F) \
+ R(reas_sec_vlan_ts_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F) \
+ R(reas_sec_vlan_ts_cksum_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | RSS_F) \
+ R(reas_sec_vlan_ts_cksum_ptype, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_vlan_ts_cksum_ptype_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F) \
+ R(reas_sec_vlan_ts_mark, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F) \
+ R(reas_sec_vlan_ts_mark_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | RSS_F) \
+ R(reas_sec_vlan_ts_mark_ptype, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F) \
+ R(reas_sec_vlan_ts_mark_ptype_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F) \
+ R(reas_sec_vlan_ts_mark_cksum, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F) \
+ R(reas_sec_vlan_ts_mark_cksum_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F) \
+ R(reas_sec_vlan_ts_mark_cksum_ptype, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F) \
+ R(reas_sec_vlan_ts_mark_cksum_ptype_rss, \
+ R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)
total: 4 errors, 2 warnings, 1 checks, 3461 lines checked
parent reply other threads:[~2022-01-20 16:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220120165310.4165567-3-gakhil@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120165500.B9FAC12091F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gakhil@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).