|WARNING| pw113914 [PATCH v1 2/4] l3fwd-power: add option to call uncore api

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: tadhgkearney <tadhg.kearney@intel.com>
Subject: |WARNING| pw113914 [PATCH v1 2/4] l3fwd-power: add option to call uncore api
Date: Mon, 11 Jul 2022 18:24:50 +0200 (CEST)	[thread overview]
Message-ID: <20220711162450.E623E120D82@dpdk.org> (raw)
In-Reply-To: <20220711162300.3308684-3-tadhg.kearney@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113914

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#66: 
This will be set for each package and die on the SKU. On exit, uncore frequency will be reverted back to previous frequency.

ERROR:TRAILING_WHITESPACE: trailing whitespace
#99: FILE: doc/guides/sample_app_ug/l3_forward_power_man.rst:377:
+Uncore frequency can be adjusted through manipulating related sysfs entries to adjust the minimum and maximum uncore values. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#110: FILE: doc/guides/sample_app_ug/l3_forward_power_man.rst:388:
+  minimum and maximum values to be the same. Frequency index's are set 100000Hz apart from $

WARNING:TYPO_SPELLING: 'decending' may be misspelled - perhaps 'descending'?
#112: FILE: doc/guides/sample_app_ug/l3_forward_power_man.rst:390:
+  Frequency index values are in decending order, ie, index 0 is maximum frequency index.

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#166: FILE: examples/l3fwd-power/main.c:158:
+static int enabled_uncore = 0;

WARNING:SPACING: missing space after struct definition
#174: FILE: examples/l3fwd-power/main.c:179:
+struct uncore_info{

WARNING:STATIC_CONST_CHAR_ARRAY: const array should probably be static const
#205: FILE: examples/l3fwd-power/main.c:1703:
+	const char filter[] = "*freq_khz*";

ERROR:TRAILING_WHITESPACE: trailing whitespace
#206: FILE: examples/l3fwd-power/main.c:1704:
+^I$

ERROR:CODE_INDENT: code indent should use tabs where possible
#208: FILE: examples/l3fwd-power/main.c:1706:
+ ^Iif (!d) {$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#208: FILE: examples/l3fwd-power/main.c:1706:
+ ^Iif (!d) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: examples/l3fwd-power/main.c:1706:
+ ^Iif (!d) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#209: FILE: examples/l3fwd-power/main.c:1707:
+ ^I^IRTE_LOG(ERR, EAL, "Unable to open uncore frequency directory");$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#209: FILE: examples/l3fwd-power/main.c:1707:
+ ^I^IRTE_LOG(ERR, EAL, "Unable to open uncore frequency directory");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#209: FILE: examples/l3fwd-power/main.c:1707:
+ ^I^IRTE_LOG(ERR, EAL, "Unable to open uncore frequency directory");$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#213: FILE: examples/l3fwd-power/main.c:1711:
+	else {
[...]
+    	while ((dir = readdir(d)) != NULL) {

WARNING:LONG_LINE_COMMENT: line length of 119 exceeds 100 columns
#214: FILE: examples/l3fwd-power/main.c:1712:
+		/* Loop through every file name in uncore frequency dir extracting pkg + die numbers from file names */

ERROR:CODE_INDENT: code indent should use tabs where possible
#215: FILE: examples/l3fwd-power/main.c:1713:
+    ^Iwhile ((dir = readdir(d)) != NULL) {$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#215: FILE: examples/l3fwd-power/main.c:1713:
+    ^Iwhile ((dir = readdir(d)) != NULL) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: examples/l3fwd-power/main.c:1713:
+    ^Iwhile ((dir = readdir(d)) != NULL) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#215: FILE: examples/l3fwd-power/main.c:1713:
+    	while ((dir = readdir(d)) != NULL) {
+			if (fnmatch(filter, dir->d_name, 0) > 0) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: examples/l3fwd-power/main.c:1722:
+    ^I}$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#224: FILE: examples/l3fwd-power/main.c:1722:
+    ^I}$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: examples/l3fwd-power/main.c:1722:
+    ^I}$

ERROR:CODE_INDENT: code indent should use tabs where possible
#225: FILE: examples/l3fwd-power/main.c:1723:
+    ^Iclosedir(d);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#225: FILE: examples/l3fwd-power/main.c:1723:
+    ^Iclosedir(d);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#225: FILE: examples/l3fwd-power/main.c:1723:
+    ^Iclosedir(d);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#226: FILE: examples/l3fwd-power/main.c:1724:
+  ^I}$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#226: FILE: examples/l3fwd-power/main.c:1724:
+  ^I}$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: examples/l3fwd-power/main.c:1724:
+  ^I}$

ERROR:CODE_INDENT: code indent should use tabs where possible
#227: FILE: examples/l3fwd-power/main.c:1725:
+  ^Ireturn(count);$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#227: FILE: examples/l3fwd-power/main.c:1725:
+  ^Ireturn(count);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: examples/l3fwd-power/main.c:1725:
+  ^Ireturn(count);$

ERROR:SPACING: space required before the open brace '{'
#240: FILE: examples/l3fwd-power/main.c:1738:
+	for (i = 0; i < total_files; i++){

ERROR:SPACING: space required before the open brace '{'
#244: FILE: examples/l3fwd-power/main.c:1742:
+		if (!strncmp(choice, "max", 3)){

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#247: FILE: examples/l3fwd-power/main.c:1745:
+				RTE_LOG(INFO, L3FWD_POWER, "Unable to set max uncore value for pkg %02u die %02u
", pkg, die);

ERROR:SPACING: space required before the open brace '{'
#250: FILE: examples/l3fwd-power/main.c:1748:
+		else if (!strncmp(choice, "min", 3)){

ERROR:SPACING: space required before the open brace '{'
#252: FILE: examples/l3fwd-power/main.c:1750:
+			if (ret == -1){

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#253: FILE: examples/l3fwd-power/main.c:1751:
+				RTE_LOG(INFO, L3FWD_POWER, "Unable to set min uncore value for pkg %02u die %02u
", pkg, die);

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#257: FILE: examples/l3fwd-power/main.c:1755:
+		}
+		else {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#260: FILE: examples/l3fwd-power/main.c:1758:
+^I^I}^I^I$

ERROR:SPACING: space required before the open brace '{'
#277: FILE: examples/l3fwd-power/main.c:1775:
+	for (i = 0; i < total_files; i++){

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#282: FILE: examples/l3fwd-power/main.c:1780:
+		int frequency_index= atoi(choice);
 		                   ^

ERROR:SPACING: space required before the open brace '{'
#284: FILE: examples/l3fwd-power/main.c:1782:
+		if (frequency_index > freq_array_len){

WARNING:LONG_LINE: line length of 144 exceeds 100 columns
#285: FILE: examples/l3fwd-power/main.c:1783:
+			RTE_LOG(INFO, L3FWD_POWER, "Frequency index given out of range, please choose a value from 0 to %d.
", freq_array_len);

ERROR:SPACING: space required before the open brace '{'
#289: FILE: examples/l3fwd-power/main.c:1787:
+		if (ret == -1){

WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#290: FILE: examples/l3fwd-power/main.c:1788:
+			RTE_LOG(INFO, L3FWD_POWER, "Unable to set uncore index value for pkg %02u die %02u
", pkg, die);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#294: FILE: examples/l3fwd-power/main.c:1792:
+^IRTE_LOG(INFO, L3FWD_POWER, "Successfully set freq index for uncore
");^I$

WARNING:SPACING: space prohibited before semicolon
#314: FILE: examples/l3fwd-power/main.c:2017:
+		case 'u': ;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#314: FILE: examples/l3fwd-power/main.c:2017:
+		case 'u': ;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#315: FILE: examples/l3fwd-power/main.c:2018:
+			const char* min = "min";

WARNING:SPACING: space prohibited before semicolon
#323: FILE: examples/l3fwd-power/main.c:2026:
+		case 'U': ;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#323: FILE: examples/l3fwd-power/main.c:2026:
+		case 'U': ;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#324: FILE: examples/l3fwd-power/main.c:2027:
+			const char* max = "max";

total: 26 errors, 27 warnings, 266 lines checked

          parent reply	other threads:[~2022-07-11 16:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220711162300.3308684-3-tadhg.kearney@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711162450.E623E120D82@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=tadhg.kearney@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).