From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Alexander Chernavin <achernavin@netgate.com>
Subject: |WARNING| pw115690 [PATCH] net/virtio: fix crash when dev is configured twice
Date: Wed, 31 Aug 2022 10:42:23 +0200 (CEST) [thread overview]
Message-ID: <20220831084223.16442121F02@dpdk.org> (raw)
In-Reply-To: <20220831084059.43918-1-achernavin@netgate.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115690
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: drivers/net/virtio/virtio_ethdev.c:2620:
+ if (hw->vqs == NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (1, 3)
#113: FILE: drivers/net/virtio/virtio_ethdev.c:2620:
+ if (hw->vqs == NULL) {
+ ret = virtio_init_device(dev, hw->req_guest_features);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: drivers/net/virtio/virtio_ethdev.c:2621:
+ ret = virtio_init_device(dev, hw->req_guest_features);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: drivers/net/virtio/virtio_ethdev.c:2622:
+ if (ret < 0)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (3, 5)
#115: FILE: drivers/net/virtio/virtio_ethdev.c:2622:
+ if (ret < 0)
+ return ret;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: drivers/net/virtio/virtio_ethdev.c:2623:
+ return ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/net/virtio/virtio_ethdev.c:2624:
+ }$
total: 0 errors, 7 warnings, 0 checks, 13 lines checked
next parent reply other threads:[~2022-08-31 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220831084059.43918-1-achernavin@netgate.com>
2022-08-31 8:42 ` checkpatch [this message]
2022-08-31 9:01 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831084223.16442121F02@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=achernavin@netgate.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).