From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rahul Bhansali <rbhansali@marvell.com>
Subject: |WARNING| pw122301 [PATCH v2 4/4] event/cnxk: restructure for cn10k datapath
Date: Wed, 18 Jan 2023 11:29:49 +0100 (CET) [thread overview]
Message-ID: <20230118102949.71ED5123659@dpdk.org> (raw)
In-Reply-To: <20230118102703.910617-4-rbhansali@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/122301
_coding style issues_
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#591: FILE: drivers/event/cnxk/cn10k_tx_worker.h:221:
+#define T(name, sz, flags) \
+ uint16_t __rte_hot cn10k_sso_hws_tx_adptr_enq_##name( \
+ void *port, struct rte_event ev[], uint16_t nb_events); \
+ uint16_t __rte_hot cn10k_sso_hws_tx_adptr_enq_seg_##name( \
+ void *port, struct rte_event ev[], uint16_t nb_events);
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#600: FILE: drivers/event/cnxk/cn10k_tx_worker.h:230:
+#define SSO_TX(fn, sz, flags) \
+ uint16_t __rte_hot fn(void *port, struct rte_event ev[], \
+ uint16_t nb_events) \
+ { \
+ struct cn10k_sso_hws *ws = port; \
+ uint64_t cmd[sz]; \
+ RTE_SET_USED(nb_events); \
+ return cn10k_sso_hws_event_tx( \
+ ws, &ev[0], cmd, (const uint64_t *)ws->tx_adptr_data, \
+ flags); \
+ }
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#612: FILE: drivers/event/cnxk/cn10k_tx_worker.h:242:
+#define SSO_TX_SEG(fn, sz, flags) \
+ uint16_t __rte_hot fn(void *port, struct rte_event ev[], \
+ uint16_t nb_events) \
+ { \
+ uint64_t cmd[(sz) + CNXK_NIX_TX_MSEG_SG_DWORDS - 2]; \
+ struct cn10k_sso_hws *ws = port; \
+ RTE_SET_USED(nb_events); \
+ return cn10k_sso_hws_event_tx( \
+ ws, &ev[0], cmd, (const uint64_t *)ws->tx_adptr_data, \
+ (flags) | NIX_TX_MULTI_SEG_F); \
+ }
total: 0 errors, 3 warnings, 2687 lines checked
parent reply other threads:[~2023-01-18 10:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230118102703.910617-4-rbhansali@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118102949.71ED5123659@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rbhansali@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).