|WARNING| pw127946 [PATCH v3] gro : ipv6-gro review comments to reduce code duplication across v4 and v6

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/127946

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

ERROR:TRAILING_WHITESPACE: trailing whitespace
#192: FILE: lib/gro/gro_tcp.c:75:
+int32_t $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#193: FILE: lib/gro/gro_tcp.c:76:
+gro_tcp_reassemble(struct rte_mbuf *pkt, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#194: FILE: lib/gro/gro_tcp.c:77:
+^Ivoid *tbl, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#195: FILE: lib/gro/gro_tcp.c:78:
+^Ivoid *key, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#219: FILE: lib/gro/gro_tcp.c:102:
+^Isent_seq = rte_be_to_cpu_32(tcp_hdr->sent_seq);^I$

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#260: FILE: lib/gro/gro_tcp.c:143:
+			if (insert_new_tcp_item(pkt, items, item_num, table_size, start_time, cur_idx,

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#303: FILE: lib/gro/gro_tcp.h:27:
+#define ASSIGN_TCP_FLOW_KEY(k1, k2) \
+	rte_ether_addr_copy(&(k1->eth_saddr), &(k2->eth_saddr)); \
+	rte_ether_addr_copy(&(k1->eth_daddr), &(k2->eth_daddr)); \
+	k2->recv_ack = k1->recv_ack; \
+	k2->src_port = k1->src_port; \
+	k2->dst_port = k1->dst_port;

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#303: FILE: lib/gro/gro_tcp.h:27:
+#define ASSIGN_TCP_FLOW_KEY(k1, k2) \
+	rte_ether_addr_copy(&(k1->eth_saddr), &(k2->eth_saddr)); \
+	rte_ether_addr_copy(&(k1->eth_daddr), &(k2->eth_daddr)); \
+	k2->recv_ack = k1->recv_ack; \
+	k2->src_port = k1->src_port; \
+	k2->dst_port = k1->dst_port;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#339: FILE: lib/gro/gro_tcp.h:86:
+delete_tcp_item(struct gro_tcp_item *items, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#340: FILE: lib/gro/gro_tcp.h:87:
+^I^Iuint32_t item_idx, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#344: FILE: lib/gro/gro_tcp.h:91:
+int32_t $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#345: FILE: lib/gro/gro_tcp.h:92:
+gro_tcp_reassemble(struct rte_mbuf *pkt, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#346: FILE: lib/gro/gro_tcp.h:93:
+^Ivoid *tbl, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#347: FILE: lib/gro/gro_tcp.h:94:
+^Ivoid *key, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#445: FILE: lib/gro/gro_tcp4.c:107:
+^IASSIGN_TCP_FLOW_KEY(src_flow, dst_flow)^I$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#504: FILE: lib/gro/gro_tcp4.c:131:
+			if (is_same_tcp4_flow(tcp4_tbl->flows[i].key, *tcp4_key)) {
+				return i;
+			}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#675: FILE: lib/gro/gro_tcp4.c:206:
+^Ireturn gro_tcp_reassemble(pkt, tbl, &key, tcp_dl, &gro_tcp4_flows_ops, tbl->items, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#676: FILE: lib/gro/gro_tcp4.c:207:
+^I^I^I^I^I^I&tbl->item_num, tbl->max_item_num, $

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#706: FILE: lib/gro/gro_tcp4.c:250:
+				j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#860: FILE: lib/gro/gro_tcp6.c:107:
+^IASSIGN_TCP_FLOW_KEY(src_flow, dst_flow)^I$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#891: FILE: lib/gro/gro_tcp6.c:147:
+			if (is_same_tcp6_flow(&tcp6_tbl->flows[i].key, tcp6_key)) {
+				return i;
+			}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1049: FILE: lib/gro/gro_tcp6.c:218:
+^Ireturn gro_tcp_reassemble(pkt, tbl, &key, tcp_dl, &gro_tcp6_flows_ops, tbl->items, $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1050: FILE: lib/gro/gro_tcp6.c:219:
+^I^I^I^I^I^I&tbl->item_num, tbl->max_item_num, $

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1060: FILE: lib/gro/gro_tcp6.c:247:
+				j = delete_tcp_item(tbl->items, j, &tbl->item_num, INVALID_ARRAY_INDEX);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1107: FILE: lib/gro/gro_tcp6.h:146:
+	if (memcmp(&k1->src_addr, &k2->src_addr, 16)) {
+		return 0;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1110: FILE: lib/gro/gro_tcp6.h:149:
+	if (memcmp(&k1->dst_addr, &k2->dst_addr, 16)) {
+		return 0;
+	}

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1114: FILE: lib/gro/gro_tcp6.h:153:
+	/*
+	* IP version (4) Traffic Class (8) Flow Label (20)

total: 18 errors, 10 warnings, 1006 lines checked