From: Thomas Monjalon <thomas@monjalon.net>
To: "Benoit Ganne (bganne)" <bganne@cisco.com>,
Mark Bloch <markb@mellanox.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"users@dpdk.org" <users@dpdk.org>,
"viacheslavo@mellanox.com" <viacheslavo@mellanox.com>,
"matan@mellanox.com" <matan@mellanox.com>,
"rasland@mellanox.com" <rasland@mellanox.com>,
"saeedm@mellanox.com" <saeedm@mellanox.com>,
"eranbe@mellanox.com" <eranbe@mellanox.com>
Subject: Re: [dpdk-users] CX4-Lx VF link status in Azure
Date: Thu, 26 Mar 2020 21:40:06 +0100 [thread overview]
Message-ID: <1712113.QCnGb9OGeP@xps> (raw)
In-Reply-To: <4c84d14c-e12f-298b-474b-0c1da812a6d2@mellanox.com>
26/03/2020 21:09, Mark Bloch:
>
> On 3/26/2020 12:00, Benoit Ganne (bganne) wrote:
> >> Pasting back this important info:
> >> "
> >> Note that ethtool and '/sys/class/net/<iface>/speed' also fails
> >> to report the link speed (but not the link status).
> >> "
> >>
> >> 26/03/2020 19:27, Benoit Ganne (bganne):
> >>> Yes everything is initialized correctly. The netdev itself is configured
> >> and usable from Linux (ping etc.). Just removing the over-strict check in
> >> mlx5 PMD is enough for everything to work fine:
> >> https://gerrit.fd.io/r/c/vpp/+/26152/1/build/external/patches/dpdk_20.02/0002-mlx5-azure-workaround.patch
> >>> The link speed is unknown but this is not issue, and link state and
> >> other link info are correctly reported.
> >>> Thomas, any input regarding this behavior in mlx5 PMD?
> >>
> >> I am not aware about the lack of link speed info.
> >> It is probably not specific to ConnectX-4 Lx.
> >> I guess it happens only with Hyper-V?
>
> Should be fixed by those 3 commits (last 1 one is just cosmetic):
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=dc392fc56f39a00a46d6db2d150571ccafe99734
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=c268ca6087f553bfc0e16ffec412b983ffe32fd4
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=2f5438ca0ee01a1b3a9c37e3f33d47c8122afe74
Thanks for the patches Mark.
> > For me there are 2 separate issues:
> > 1) Linux kernel driver does not report link speed in Azure for CX4-Lx in Ubuntu 18.04
1 looks to be addressed with patches above.
> > 2) mlx5 PMD enforce that both link speed is defined and link is up to update interface state
Yes we can look at this issue.
> > If (1) is fixed, (2) should work, but to me (2) is too strict
> > for no good reason: we do not really care about reported link speed,
I agree that link speed is less important than link status.
> > esp in a virtual environment it usually does not mean much,
Yes the link speed is shared between all VFs.
> > but we do care about link state.
next prev parent reply other threads:[~2020-03-26 20:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 19:07 Benoit Ganne (bganne)
2020-03-25 21:32 ` Stephen Hemminger
2020-03-25 22:48 ` Stephen Hemminger
2020-03-26 14:26 ` Benoit Ganne (bganne)
2020-03-26 17:57 ` Stephen Hemminger
2020-03-26 18:27 ` Benoit Ganne (bganne)
2020-03-26 18:52 ` Thomas Monjalon
2020-03-26 19:00 ` Benoit Ganne (bganne)
2020-03-26 20:09 ` Mark Bloch
2020-03-26 20:40 ` Thomas Monjalon [this message]
2020-03-26 21:31 ` Thomas Monjalon
2020-03-27 10:02 ` Benoit Ganne (bganne)
2020-03-27 10:13 ` Thomas Monjalon
2020-03-27 17:26 ` Benoit Ganne (bganne)
2020-03-27 22:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1712113.QCnGb9OGeP@xps \
--to=thomas@monjalon.net \
--cc=bganne@cisco.com \
--cc=eranbe@mellanox.com \
--cc=markb@mellanox.com \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=users@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).