DPDK usage discussions
 help / color / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Benoit Ganne (bganne)" <bganne@cisco.com>
Cc: "users@dpdk.org" <users@dpdk.org>,
	"viacheslavo@mellanox.com" <viacheslavo@mellanox.com>,
	"matan@mellanox.com" <matan@mellanox.com>,
	"rasland@mellanox.com" <rasland@mellanox.com>
Subject: Re: [dpdk-users] CX4-Lx VF link status in Azure
Date: Fri, 27 Mar 2020 11:13:34 +0100
Message-ID: <2609429.XrmoMso0CX@xps> (raw)
In-Reply-To: <CH2PR11MB43279B84D5F6DF016918FB36C1CC0@CH2PR11MB4327.namprd11.prod.outlook.com>

27/03/2020 11:02, Benoit Ganne (bganne):
> > Second, as Benoit said, we should relax this requirement.
> > If the link speed is unknown, a second request can be tried, no more.
> > Benoit, feel free to submit a patch showing how you think it should
> > behave.
> > Otherwise, I guess a maintainer of mlx5 will try to arrange it later.
> > Note: a patch (even not perfect) is usually speeding up resolution.
> 
> I can do that, but I am not sure I understand the logic of this test to begin with: looking into other PMD (mlx4, i40e), it seems to be the only one worrying about updating link state only when "ready" for some not clear (to me) definition of "ready".
> I'll tend to agree with other PMD here: if the syscalls did not failed we should just update with what we know.
> Why was this test introduced and what did it fixed?

Unfortunately the reason was not documented.
I suggest we go with a patch from your understanding
and we'll test it in multiple conditions to validate nothing is broken.



  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 19:07 Benoit Ganne (bganne)
2020-03-25 21:32 ` Stephen Hemminger
2020-03-25 22:48 ` Stephen Hemminger
2020-03-26 14:26   ` Benoit Ganne (bganne)
2020-03-26 17:57     ` Stephen Hemminger
2020-03-26 18:27       ` Benoit Ganne (bganne)
2020-03-26 18:52         ` Thomas Monjalon
2020-03-26 19:00           ` Benoit Ganne (bganne)
2020-03-26 20:09             ` Mark Bloch
2020-03-26 20:40               ` Thomas Monjalon
2020-03-26 21:31                 ` Thomas Monjalon
2020-03-27 10:02                   ` Benoit Ganne (bganne)
2020-03-27 10:13                     ` Thomas Monjalon [this message]
2020-03-27 17:26                       ` Benoit Ganne (bganne)
2020-03-27 22:34                         ` Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2609429.XrmoMso0CX@xps \
    --to=thomas@monjalon.net \
    --cc=bganne@cisco.com \
    --cc=matan@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=users@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK usage discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/users/0 users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 users users/ http://inbox.dpdk.org/users \
		users@dpdk.org
	public-inbox-index users


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.users


AGPL code for this site: git clone https://public-inbox.org/ public-inbox