DPDK usage discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Rob Scheepens <rob.scheepens@nutanix.com>
Cc: "users@dpdk.org" <users@dpdk.org>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-users] Build on Windows not working: "ERROR: Program 'echo' not found"
Date: Wed, 30 Jun 2021 12:28:07 +0300	[thread overview]
Message-ID: <20210630122807.1cdeb496@sovereign> (raw)
In-Reply-To: <997A3507-0829-4A9A-8402-C87F34556162@nutanix.com>

2021-06-30 08:41 (UTC+0000), Rob Scheepens:
> Hello Dmitry,
> 
> That works, thanks!
> 
> Is there an issue open for this? If not, should I create one?

Not yet and I'm not sure is it Meson or DPDK issue.
Meson's behavior changed between 0.57 and 0.58.1
seemingly due to another feature added, on the other hand,
DPDK code didn't work on Windows as expected.

+Bruce, build system maintainer.
I think we'll sort this out, thank you for reporting the bug.

Bruce, in doc/meson.build, we have this:

doc_targets = []
doc_target_names = []
subdir('api')
subdir('guides')

if doc_targets.length() == 0
    message = 'No docs targets found'
else
    message = 'Building docs:'
endif
run_target('doc', command: ['echo', message, doc_target_names],
    depends: doc_targets)

First, why there's no early exit if enable_docs=false?

Second, with Meson 0.57 there's not error on Windows,
but the message is not printed either.
The root cause is there's no `echo` binary on Windows, it's a builtin.
However, when I tried to replace it like so,
0.58.1 gives no error, but also prints nothing:

run_target('doc', command: ['cmd', '/C', 'echo', message, doc_target_names],
    depends: doc_targets)

Although in the log it says it searched for `cmd` and found it.
Could Meson 0.47.1 print a message as required by itself, without echo?

  reply	other threads:[~2021-06-30  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 15:39 Rob Scheepens
2021-06-29 20:49 ` Dmitry Kozlyuk
2021-06-30  8:41   ` Rob Scheepens
2021-06-30  9:28     ` Dmitry Kozlyuk [this message]
2021-06-30 11:11       ` Richardson, Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210630122807.1cdeb496@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=rob.scheepens@nutanix.com \
    --cc=users@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).