From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Rob Scheepens <rob.scheepens@nutanix.com>
Cc: "users@dpdk.org" <users@dpdk.org>, "bluca@debian.org" <bluca@debian.org>
Subject: Re: [dpdk-users] Build on Windows not working: "ERROR: Program 'echo' not found"
Date: Wed, 30 Jun 2021 11:11:42 +0000 [thread overview]
Message-ID: <bf2f86256d1f48c6beb48e23eecf419f@intel.com> (raw)
In-Reply-To: <20210630122807.1cdeb496@sovereign>
+Luca who also helped with getting docs building
> -----Original Message-----
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Sent: Wednesday, June 30, 2021 10:28 AM
> To: Rob Scheepens <rob.scheepens@nutanix.com>
> Cc: users@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [dpdk-users] Build on Windows not working: "ERROR: Program
> 'echo' not found"
>
> 2021-06-30 08:41 (UTC+0000), Rob Scheepens:
> > Hello Dmitry,
> >
> > That works, thanks!
> >
> > Is there an issue open for this? If not, should I create one?
>
> Not yet and I'm not sure is it Meson or DPDK issue.
> Meson's behavior changed between 0.57 and 0.58.1
> seemingly due to another feature added, on the other hand,
> DPDK code didn't work on Windows as expected.
>
> +Bruce, build system maintainer.
> I think we'll sort this out, thank you for reporting the bug.
>
> Bruce, in doc/meson.build, we have this:
>
> doc_targets = []
> doc_target_names = []
> subdir('api')
> subdir('guides')
>
> if doc_targets.length() == 0
> message = 'No docs targets found'
> else
> message = 'Building docs:'
> endif
> run_target('doc', command: ['echo', message, doc_target_names],
> depends: doc_targets)
>
> First, why there's no early exit if enable_docs=false?
>
Looking through the code, I believe things are done this way so that, if we have the dependencies of sphinx and doxygen, you can do "ninja doc" to build the documentation even if "enable_docs" is set to false. We always have a valid "doc" target, irrespective of that setting, which controls only whether the docs are built as part of a regular build or not.
Regards,
/Bruce
prev parent reply other threads:[~2021-06-30 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 15:39 Rob Scheepens
2021-06-29 20:49 ` Dmitry Kozlyuk
2021-06-30 8:41 ` Rob Scheepens
2021-06-30 9:28 ` Dmitry Kozlyuk
2021-06-30 11:11 ` Richardson, Bruce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf2f86256d1f48c6beb48e23eecf419f@intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=rob.scheepens@nutanix.com \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).