DPDK usage discussions
 help / color / mirror / Atom feed
From: satish amara <satishkamara@gmail.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"users@dpdk.org" <users@dpdk.org>,
	 "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: Fwd: QOS sample example.
Date: Fri, 1 Apr 2022 09:34:29 -0400	[thread overview]
Message-ID: <CAGSLe_E6kAEcNRjieXbasR0Q=A3yXbPJ=47_=-kbMmuPZZUd5Q@mail.gmail.com> (raw)
In-Reply-To: <CY4PR11MB1589D70C098258334421B44FE0E09@CY4PR11MB1589.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2528 bytes --]

Thanks for the info Jasvinder. I see there is an internal timer to see when
to refill the token buckets and credits.  I have read the QOS  document.
My understanding is that the DPDK code is using the same HQOS thread CPU
context to implement timer functionality during the pipe selection and not
leveraging on Linux timers or other timers.

Regards,
Satish Amara

On Fri, Apr 1, 2022 at 4:36 AM Singh, Jasvinder <jasvinder.singh@intel.com>
wrote:

> Hi Satish,
>
>
>
> DPDK HQoS scheduler has internal timer to compute the credits. The time
> difference between the two consecutive visit to the same pipe is used to
> compute the number of tb_periods elapsed and based on that, the available
> credits in the token bucket is computed. Each pipe has its own context
> which stores the timestamp of the last visit  and it is used when pipe is
> visited to schedule the packets from its queues.
>
>
>
> Thanks,
>
> Jasvinder
>
>
>
>
>
>
>
> *From:* satish amara <satishkamara@gmail.com>
> *Sent:* Thursday, March 31, 2022 9:27 PM
> *To:* Thomas Monjalon <thomas@monjalon.net>
> *Cc:* users@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> *Subject:* Re: Fwd: QOS sample example.
>
>
>
> Thanks, Thomas for forwarding this to the group.
>
> I have one more question. Does DPDK QOS  uses any internal threads/timers
> for the token bucket implementation?. The token
>
>  buckets can be implemented in different ways.  When are the tokens are
> filled, I see there is tb_period?
>
> It looks like the tokens are filled when the HQOS thread is trying to find
> the next active pipe?
>
>
>
> Regards,
>
> Satish Amara
>
>
>
>
>
>
>
> On Thu, Mar 31, 2022 at 3:39 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
>
> +Cc QoS scheduler maintainers (see file MAINTAINERS)
>
> 31/03/2022 18:59, satish amara:
> > Hi,
> >     I am trying to understand the QOS sample scheduler application code.
> > Trying to understand what is tc_period in the config.
> > 30. QoS Scheduler Sample Application — Data Plane Development Kit 21.05.0
> > documentation (dpdk.org)
> > <https://doc.dpdk.org/guides-21.05/sample_app_ug/qos_scheduler.html> Is
> > tc_period same as  tb_period
> > tb_period Bytes Time period that should elapse since the last credit
> update
> > in order for the bucket to be awarded tb_credits_per_period worth or
> > credits.
> > Regards,
> > Satish Amara
> >
>
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 5151 bytes --]

  reply	other threads:[~2022-04-01 13:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 20:20 satish amara
2022-03-31 16:59 ` Fwd: " satish amara
2022-03-31 19:39   ` Thomas Monjalon
2022-03-31 20:26     ` satish amara
2022-04-01  8:36       ` Singh, Jasvinder
2022-04-01 13:34         ` satish amara [this message]
2022-04-06 15:32           ` satish amara
2022-04-06 16:34             ` Singh, Jasvinder
2022-04-06 18:06               ` satish amara
2022-04-07 17:29                 ` Singh, Jasvinder
2022-04-11 17:19                   ` satish amara
2022-03-31 20:28     ` Singh, Jasvinder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGSLe_E6kAEcNRjieXbasR0Q=A3yXbPJ=47_=-kbMmuPZZUd5Q@mail.gmail.com' \
    --to=satishkamara@gmail.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=jasvinder.singh@intel.com \
    --cc=thomas@monjalon.net \
    --cc=users@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).