DPDK usage discussions
 help / color / mirror / Atom feed
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: satish amara <satishkamara@gmail.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"users@dpdk.org" <users@dpdk.org>,
	 "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: RE: Fwd: QOS sample example.
Date: Thu, 7 Apr 2022 17:29:43 +0000
Message-ID: <CY4PR11MB158922E156EDF86E6BB0754DE0E69@CY4PR11MB1589.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAGSLe_FtZN-1AOBV_5SYxxJ4YaozpAiX8HL-fUo_eQwreOqB7A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 6597 bytes --]

Hi Satish,

I would encourage you to have a look at library code especially around dequeue operation to understand the scheduling behaviour.

Some of the answers are inline;


From: satish amara <satishkamara@gmail.com>
Sent: Wednesday, April 6, 2022 7:06 PM
To: Singh, Jasvinder <jasvinder.singh@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>; users@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
Subject: Re: Fwd: QOS sample example.

Thank you. I have a question about how the active Traffic class is selected in a pipe.
Let's say I have  confugured only one Subport and  one  Pipe on interface.
If the highest priority traffic class in a pipe has exhausted it's rate limit can lower traffic class in the same pipe  be dequeued.

Yes.once highest priority TC has consumed its allocated credits, and at the pipe level, there are credits available, then packets from next priority tc will be scheduled.

Can I have profile for Pipe where bandwidth for Pipe is shared among multiple TC's
Here is an example how I want to configure pipe so bandwidth allocated to Pipe is shared among 13 classes giving priority to highest queue provided it didn't exceed the rate limit.

pipe_profile 0 {
tb_rate 1300000 /* Pipe level token bucket rate (bytes per second) */
tb_size 1000000 /* Pipe level token bucket size (bytes) */
tc0_rate 100000 /* Pipe level token bucket rate for traffic class 0 (bytes per second) */
tc1_rate 100000 /* Pipe level token bucket rate for traffic class 1 (bytes per second) */
tc2_rate 100000 /* Pipe level token bucket rate for traffic class 2 (bytes per second) */
tc3_rate 100000
..... /* Pipe level token bucket rate for traffic class 3 (bytes per second) */
tc13_rate 100000
tc_period 40 /* Time int

DPDK QoS sample app has such profile defined if that helps.

 The scheduling decision to send next packet from (subport S, pipe P, traffic class TC, queue Q) is favorable (packet is sent) when all the conditions below are met:
·         Pipe P of subport S is currently selected by one of the port grinders;
·         Traffic class TC is the highest priority active traffic class of pipe P;
·         Queue Q is the next queue selected by WRR within traffic class TC of pipe P;
·         Subport S has enough credits to send the packet;
·         Subport S has enough credits for traffic class TC to send the packet;
·         Pipe P has enough credits to send the packet;
·         Pipe P has enough credits for traffic class TC to send the packet.

If all the above conditions are met, then the packet is selected for transmission and the necessary credits are subtracted from subport S, subport S traffic class TC, pipe P, pipe P traffic class TC.

Yes, have a look at the grinder_credits_check () function in the library code.

On Wed, Apr 6, 2022 at 12:34 PM Singh, Jasvinder <jasvinder.singh@intel.com<mailto:jasvinder.singh@intel.com>> wrote:
Yes, it is fixed. The tc_credits_per_period is updated after tc_period duration. Note that tc credits don’t get accumulated if tc queue is visited after multiple tc_period due to rate limiting mechanism at the traffic class level.

From: satish amara <satishkamara@gmail.com<mailto:satishkamara@gmail.com>>
Sent: Wednesday, April 6, 2022 4:32 PM
To: Singh, Jasvinder <jasvinder.singh@intel.com<mailto:jasvinder.singh@intel.com>>
Cc: Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>>; users@dpdk.org<mailto:users@dpdk.org>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com<mailto:cristian.dumitrescu@intel.com>>
Subject: Re: Fwd: QOS sample example.

   I have a few more questions.
Can you provide  some clarity on
tc_period is for how often the credits for traffic need to be updated. Is tc_credits_per_period is fixed based on tc_rate.

Satish Amara

On Fri, Apr 1, 2022 at 9:34 AM satish amara <satishkamara@gmail.com<mailto:satishkamara@gmail.com>> wrote:
Thanks for the info Jasvinder. I see there is an internal timer to see when to refill the token buckets and credits.  I have read the QOS  document.  My understanding is that the DPDK code is using the same HQOS thread CPU context to implement timer functionality during the pipe selection and not leveraging on Linux timers or other timers.

Satish Amara

On Fri, Apr 1, 2022 at 4:36 AM Singh, Jasvinder <jasvinder.singh@intel.com<mailto:jasvinder.singh@intel.com>> wrote:
Hi Satish,

DPDK HQoS scheduler has internal timer to compute the credits. The time difference between the two consecutive visit to the same pipe is used to compute the number of tb_periods elapsed and based on that, the available credits in the token bucket is computed. Each pipe has its own context which stores the timestamp of the last visit  and it is used when pipe is visited to schedule the packets from its queues.


From: satish amara <satishkamara@gmail.com<mailto:satishkamara@gmail.com>>
Sent: Thursday, March 31, 2022 9:27 PM
To: Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>>
Cc: users@dpdk.org<mailto:users@dpdk.org>; Singh, Jasvinder <jasvinder.singh@intel.com<mailto:jasvinder.singh@intel.com>>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com<mailto:cristian.dumitrescu@intel.com>>
Subject: Re: Fwd: QOS sample example.

Thanks, Thomas for forwarding this to the group.
I have one more question. Does DPDK QOS  uses any internal threads/timers for the token bucket implementation?. The token
 buckets can be implemented in different ways.  When are the tokens are filled, I see there is tb_period?
It looks like the tokens are filled when the HQOS thread is trying to find the next active pipe?

Satish Amara

On Thu, Mar 31, 2022 at 3:39 PM Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote:
+Cc QoS scheduler maintainers (see file MAINTAINERS)

31/03/2022 18:59, satish amara:
> Hi,
>     I am trying to understand the QOS sample scheduler application code.
> Trying to understand what is tc_period in the config.
> 30. QoS Scheduler Sample Application — Data Plane Development Kit 21.05.0
> documentation (dpdk.org<http://dpdk.org>)
> <https://doc.dpdk.org/guides-21.05/sample_app_ug/qos_scheduler.html> Is
> tc_period same as  tb_period
> tb_period Bytes Time period that should elapse since the last credit update
> in order for the bucket to be awarded tb_credits_per_period worth or
> credits.
> Regards,
> Satish Amara

[-- Attachment #2: Type: text/html, Size: 26207 bytes --]

  reply	other threads:[~2022-04-07 17:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 20:20 satish amara
2022-03-31 16:59 ` Fwd: " satish amara
2022-03-31 19:39   ` Thomas Monjalon
2022-03-31 20:26     ` satish amara
2022-04-01  8:36       ` Singh, Jasvinder
2022-04-01 13:34         ` satish amara
2022-04-06 15:32           ` satish amara
2022-04-06 16:34             ` Singh, Jasvinder
2022-04-06 18:06               ` satish amara
2022-04-07 17:29                 ` Singh, Jasvinder [this message]
2022-04-11 17:19                   ` satish amara
2022-03-31 20:28     ` Singh, Jasvinder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR11MB158922E156EDF86E6BB0754DE0E69@CY4PR11MB1589.namprd11.prod.outlook.com \
    --to=jasvinder.singh@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=satishkamara@gmail.com \
    --cc=thomas@monjalon.net \
    --cc=users@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK usage discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/users/0 users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 users users/ http://inbox.dpdk.org/users \
	public-inbox-index users

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git