DPDK usage discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Ido Goshen <Ido@cgstowernetworks.com>,
	"users@dpdk.org" <users@dpdk.org>,  "dev@dpdk.org" <dev@dpdk.org>
Cc: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: RE: Does ACL support field size of 8 bytes?
Date: Tue, 26 Apr 2022 17:56:43 +0000
Message-ID: <DM6PR11MB4491A9ADB259DA199E8791A79AFB9@DM6PR11MB4491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <AS4PR09MB5525D74A4559B241F03BB981D6EC9@AS4PR09MB5525.eurprd09.prod.outlook.com>


Hi Ido,

> I've lots of good experience with ACL but can't make it work with u64 values
> I know it can be split to 2xu32 fields, but it makes it more complex to use and a wastes double  number of fields (we hit the
> RTE_ACL_MAX_FIELDS 64 limit)

Wow, that's a lot of fields...

> According to the documentation and rte_acl.h fields size can be 8 bytes (u64)
> e.g.
>   'The size parameter defines the length of the field in bytes. Allowable values are 1, 2, 4, or 8 bytes.'
>   (from https://doc.dpdk.org/guides-21.11/prog_guide/packet_classif_access_ctrl.html#rule-definition)
> 
> Though there's a hint it's less recommended
>   'Also, it is best to define fields of 8 or more bytes as 4 byte fields so that the build processes can eliminate fields that are all wild.'
>
> It's also not clear how it fits in a group (i.e. what's input_index stride) which is only 4 bytes
>     'All subsequent fields has to be grouped into sets of 4 consecutive bytes.'
> 
> I couldn't find any example or test app that's using 8 bytes
> e.g. for IPv6 address 4xu32 fields are always used and not 2xu64
> 
> Should it work?
> Did anyone try it successfully and/or can share an example?

You are right: though it is formally supported, we do not test it, and AFAIK no-one used it till now.
As we do group fields by 4B long chunks anyway, 8B field is sort of awkward and confusing.
To be honest, I don't even remember what was the rationale beyond introducing it at first place.
Anyway, just submitted patches that should fix 8B field support (at least it works for me now):
https://patches.dpdk.org/project/dpdk/list/?series=22676
Please give it a try.
In long term it probably would be good to hear from you and other users, should we keep 8B
support at all, or might be it would be easier just to abandon it.
Thanks
Konstantin 


 




  reply	other threads:[~2022-04-28 11:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 13:55 Ido Goshen
2022-04-26 17:56 ` Ananyev, Konstantin [this message]
2022-04-26 17:58   ` Fwd: " Konstantin Ananyev
2022-05-11 14:28   ` Ido Goshen
2022-05-15 20:53     ` Konstantin Ananyev
2022-05-16  6:28       ` Ido Goshen
2022-05-17 23:43         ` Konstantin Ananyev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4491A9ADB259DA199E8791A79AFB9@DM6PR11MB4491.namprd11.prod.outlook.com \
    --to=konstantin.ananyev@intel.com \
    --cc=Ido@cgstowernetworks.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=users@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK usage discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/users/0 users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 users users/ http://inbox.dpdk.org/users \
		users@dpdk.org
	public-inbox-index users

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git