DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
	dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v2 3/7] baseband/acc: acc100 fix multiplexing multiple ops
Date: Fri, 6 Jan 2023 09:57:45 +0100	[thread overview]
Message-ID: <010df385-49df-f5d7-340c-1a4202cad37c@redhat.com> (raw)
In-Reply-To: <20230106054443.199473-4-hernan.vargas@intel.com>



On 1/6/23 06:44, Hernan Vargas wrote:
> Function to check if multiplexing is possible for multiple operations in
> one descriptor returns number of enqueued ops.
> 
> Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code")
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index d77d3b77b5..2f65f290b5 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -3423,9 +3423,9 @@ acc100_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data,
>   		}
>   		avail--;
>   		enq = RTE_MIN(left, ACC_MUX_5GDL_DESC);
> -		if (check_mux(&ops[i], enq)) {
> -			ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i],
> -					desc_idx, enq);
> +		enq = check_mux(&ops[i], enq);
> +		if (enq > 1) {
> +			ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i], desc_idx, enq);
>   			if (ret < 0) {
>   				acc_enqueue_invalid(q_data);
>   				break;

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2023-01-06  8:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06  5:44 [PATCH v2 0/7] baseband/acc: changes for 23.03 Hernan Vargas
2023-01-06  5:44 ` [PATCH v2 1/7] baseband/acc: acc100 free harq layout pointer Hernan Vargas
2023-01-06  8:53   ` Maxime Coquelin
2023-01-11 16:45     ` Vargas, Hernan
2023-01-06  5:44 ` [PATCH v2 2/7] baseband/acc: acc100 fix iteration counter in TB Hernan Vargas
2023-01-06  8:54   ` Maxime Coquelin
2023-01-06  5:44 ` [PATCH v2 3/7] baseband/acc: acc100 fix multiplexing multiple ops Hernan Vargas
2023-01-06  8:57   ` Maxime Coquelin [this message]
2023-01-06  5:44 ` [PATCH v2 4/7] baseband/acc: acc100 fix queue mapping to 64 bits Hernan Vargas
2023-01-06  9:12   ` Maxime Coquelin
2023-01-06  9:13     ` Maxime Coquelin
2023-01-06 22:06       ` Vargas, Hernan
2023-01-06  5:44 ` [PATCH v2 5/7] baseband/acc: acc100 use define constant Hernan Vargas
2023-01-06  9:13   ` Maxime Coquelin
2023-01-06  5:44 ` [PATCH v2 6/7] baseband/acc: acc100 use desc helper functions Hernan Vargas
2023-01-06 14:11   ` Maxime Coquelin
2023-01-06  5:44 ` [PATCH v2 7/7] baseband/acc: acc100 ignore missing mempools Hernan Vargas
2023-01-06 14:39   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010df385-49df-f5d7-340c-1a4202cad37c@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hernan.vargas@intel.com \
    --cc=nicolas.chautru@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).