From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yan, Zhirun" <zhirun.yan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Wang, Haiyue" <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: remove redundant code in free queues.
Date: Mon, 10 Dec 2018 12:36:26 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532FC030@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181210133205.70401-1-zhirun.yan@intel.com>
> -----Original Message-----
> From: Yan, Zhirun
> Sent: Monday, December 10, 2018 9:32 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Cc: Yan, Zhirun <zhirun.yan@intel.com>
> Subject: [PATCH v1] net/i40e: remove redundant code in free queues.
>
> Before this patch, there are two functions that will clear RX/TX queues
> number: rte_eth_dev_close() and i40e_dev_free_queues().
I agree with what the patch changed, but the commit log is not comprehensive.
I40e_dev_free_queues is not only in the path of rte_eth_dev_close but also rte_eth_dev_reset.
So
For rte_eth_dev_close, its redundant because of duplication.
For rte_eth_dev_reset its redundant because of not necessary, since following dev_configure is required after dev_reset and it will be updated correctly.
>
> This patch remove redundant code in i40e_dev_free_queues().
>
> Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> e1152ff0e..cc953ad58 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -2753,7 +2753,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)
> i40e_dev_rx_queue_release(dev->data->rx_queues[i]);
> dev->data->rx_queues[i] = NULL;
> }
> - dev->data->nb_rx_queues = 0;
>
> for (i = 0; i < dev->data->nb_tx_queues; i++) {
> if (!dev->data->tx_queues[i])
> @@ -2761,7 +2760,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)
> i40e_dev_tx_queue_release(dev->data->tx_queues[i]);
> dev->data->tx_queues[i] = NULL;
> }
> - dev->data->nb_tx_queues = 0;
> }
>
> #define I40E_FDIR_NUM_TX_DESC I40E_MIN_RING_DESC
> --
> 2.17.1
next prev parent reply other threads:[~2018-12-10 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 13:32 Zhirun Yan
2018-12-10 12:36 ` Zhang, Qi Z [this message]
2018-12-10 12:47 ` Wang, Haiyue
2018-12-10 14:08 ` Zhang, Qi Z
2018-12-10 16:59 ` Wang, Haiyue
2018-12-11 1:21 ` Zhang, Qi Z
2018-12-11 2:28 ` Wang, Haiyue
2018-12-13 12:46 ` [dpdk-dev] [PATCH v2] net/i40e: remove redundant code Zhirun Yan
2018-12-13 12:49 ` Zhirun Yan
2018-12-13 9:57 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532FC030@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).