From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yan, Zhirun" <zhirun.yan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wang, Haiyue" <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove redundant code
Date: Thu, 13 Dec 2018 09:57:41 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532FE597@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181213124928.25154-1-zhirun.yan@intel.com>
> -----Original Message-----
> From: Yan, Zhirun
> Sent: Thursday, December 13, 2018 8:49 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Yan, Zhirun <zhirun.yan@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH v2] net/i40e: remove redundant code
>
> Before this patch, there are two functions will call i40e_dev_free_queues to free
> queues. For rte_eth_dev_close(), its redundant because of duplication. For
> rte_eth_dev_reset() its redundant because of not necessary, since following
> dev_configure is required after dev_reset and it will be updated correctly.
>
> This patch removes redundant code in i40e_dev_free_queues().
>
> Fixes: 6b4537128394 ("i40e: free queue memory when closing")
>
> Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2018-12-13 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 13:32 [dpdk-dev] [PATCH v1] net/i40e: remove redundant code in free queues Zhirun Yan
2018-12-10 12:36 ` Zhang, Qi Z
2018-12-10 12:47 ` Wang, Haiyue
2018-12-10 14:08 ` Zhang, Qi Z
2018-12-10 16:59 ` Wang, Haiyue
2018-12-11 1:21 ` Zhang, Qi Z
2018-12-11 2:28 ` Wang, Haiyue
2018-12-13 12:46 ` [dpdk-dev] [PATCH v2] net/i40e: remove redundant code Zhirun Yan
2018-12-13 12:49 ` Zhirun Yan
2018-12-13 9:57 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532FE597@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).