From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>
Subject: Re: [RFC PATCH v2 3/5] net/bonding: move testpmd commands
Date: Fri, 20 May 2022 09:55:47 +0300 [thread overview]
Message-ID: <103050ec-70aa-9d28-fc42-7c40072196ff@oktetlabs.ru> (raw)
In-Reply-To: <20220518194649.1868574-4-david.marchand@redhat.com>
On 5/18/22 22:46, David Marchand wrote:
> Move related specific testpmd commands into this driver directory.
> While at it, fix checkpatch warnings.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
LGTM, just a couple of nits below. Anyway
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
[snip]
> diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build
> index 402b44be1a..faea892295 100644
> --- a/drivers/net/bonding/meson.build
> +++ b/drivers/net/bonding/meson.build
> @@ -16,6 +16,7 @@ sources = files(
> 'rte_eth_bond_flow.c',
> 'rte_eth_bond_pmd.c',
> )
> +testpmd_sources = files('rte_eth_bond_testpmd.c')
I'd not follow bonding naming conventions above and
name the file as you do for i40e and ixgbe: bond_testpmd.c
I think naming scheme used in bonding and some other PMDs is
legacy.
>
> deps += 'sched' # needed for rte_bitmap.h
> deps += ['ip_frag']
> diff --git a/drivers/net/bonding/rte_eth_bond_testpmd.c b/drivers/net/bonding/rte_eth_bond_testpmd.c
> new file mode 100644
[snip]
> +static cmdline_parse_token_string_t cmd_setbonding_mode_set =
> +TOKEN_STRING_INITIALIZER(struct cmd_set_bonding_mode_result,
> + set, "set");
I think TOKEN should be one TAB aligned above as it is done
for the most of cases in the code.
> +static cmdline_parse_token_string_t cmd_setbonding_mode_bonding =
> +TOKEN_STRING_INITIALIZER(struct cmd_set_bonding_mode_result,
> + bonding, "bonding");
> +static cmdline_parse_token_string_t cmd_setbonding_mode_mode =
> +TOKEN_STRING_INITIALIZER(struct cmd_set_bonding_mode_result,
> + mode, "mode");
> +static cmdline_parse_token_num_t cmd_setbonding_mode_value =
> +TOKEN_NUM_INITIALIZER(struct cmd_set_bonding_mode_result,
> + value, RTE_UINT8);
> +static cmdline_parse_token_num_t cmd_setbonding_mode_port =
> +TOKEN_NUM_INITIALIZER(struct cmd_set_bonding_mode_result,
> + port_id, RTE_UINT16);
> +
> +static cmdline_parse_inst_t cmd_set_bonding_mode = {
> + .f = cmd_set_bonding_mode_parsed,
> + .help_str = "set bonding mode <mode_value> <port_id>: "
> + "Set the bonding mode for port_id",
> + .data = NULL,
> + .tokens = {
> + (void *)&cmd_setbonding_mode_set,
> + (void *)&cmd_setbonding_mode_bonding,
> + (void *)&cmd_setbonding_mode_mode,
> + (void *)&cmd_setbonding_mode_value,
> + (void *)&cmd_setbonding_mode_port,
> + NULL
> + }
While on it, I'd fix above alignments to be just one TAB per
level. I don't understand why 2 TABs per level is used above.
[snip]
next prev parent reply other threads:[~2022-05-20 6:55 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 7:57 [RFC PATCH 0/4] Split driver specific commands out of testpmd David Marchand
2022-05-13 7:57 ` [RFC PATCH 1/4] app/testpmd: register driver specific commands David Marchand
2022-05-13 10:30 ` David Marchand
2022-05-13 7:57 ` [RFC PATCH 2/4] net/bonding: move testpmd commands David Marchand
2022-05-13 10:09 ` Min Hu (Connor)
2022-05-18 17:24 ` David Marchand
2022-05-18 23:25 ` Konstantin Ananyev
2022-05-19 7:40 ` David Marchand
2022-05-19 11:26 ` Thomas Monjalon
2022-05-20 6:59 ` Andrew Rybchenko
2022-05-24 9:40 ` Konstantin Ananyev
2022-05-24 10:15 ` Thomas Monjalon
2022-05-24 22:41 ` Konstantin Ananyev
2022-05-13 7:57 ` [RFC PATCH 3/4] net/i40e: " David Marchand
2022-05-13 7:57 ` [RFC PATCH 4/4] net/ixgbe: " David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 1/5] app/testpmd: mark cmdline symbols as static David Marchand
2022-05-20 6:28 ` Andrew Rybchenko
2022-05-18 19:46 ` [RFC PATCH v2 2/5] app/testpmd: register driver specific commands David Marchand
2022-05-20 6:55 ` Andrew Rybchenko
2022-05-18 19:46 ` [RFC PATCH v2 3/5] net/bonding: move testpmd commands David Marchand
2022-05-20 6:55 ` Andrew Rybchenko [this message]
2022-05-18 19:46 ` [RFC PATCH v2 4/5] net/i40e: " David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 5/5] net/ixgbe: " David Marchand
2022-05-20 7:04 ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd Andrew Rybchenko
2022-05-23 7:10 ` [PATCH 0/6] " David Marchand
2022-05-23 7:10 ` [PATCH 1/6] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-23 10:19 ` Dumitrescu, Cristian
2022-05-23 18:09 ` Ferruh Yigit
2022-05-23 7:10 ` [PATCH 2/6] app/testpmd: register driver specific commands David Marchand
2022-05-23 18:10 ` Ferruh Yigit
2022-05-24 10:53 ` David Marchand
2022-05-24 11:43 ` Ferruh Yigit
2022-05-24 17:21 ` Thomas Monjalon
2022-05-24 17:44 ` David Marchand
2022-05-24 17:51 ` Thomas Monjalon
2022-05-23 7:10 ` [PATCH 3/6] net/bonding: move testpmd commands David Marchand
2022-05-23 18:10 ` Ferruh Yigit
2022-06-17 5:06 ` [PATCH v2] " David Marchand
2022-06-20 17:53 ` Ferruh Yigit
2022-05-23 7:10 ` [PATCH 4/6] net/i40e: " David Marchand
2022-06-17 5:07 ` [PATCH v2] " David Marchand
2022-06-20 17:53 ` Ferruh Yigit
2022-05-23 7:10 ` [PATCH 5/6] app/testpmd: drop ixgbe bypass commands David Marchand
2022-05-23 18:10 ` Ferruh Yigit
2022-06-17 5:07 ` [PATCH v2 1/3] app/testpmd: restore " David Marchand
2022-06-17 5:07 ` [PATCH v2 2/3] net/ixgbe: move testpmd commands David Marchand
2022-06-17 5:07 ` [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-06-20 19:04 ` Ferruh Yigit
2022-06-23 12:35 ` Zhang, Qi Z
2022-07-21 8:05 ` [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands David Marchand
2022-07-21 8:05 ` [PATCH v3 2/3] net/ixgbe: move testpmd commands David Marchand
2022-07-21 8:05 ` [PATCH v3 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-08-25 10:37 ` Ferruh Yigit
2022-08-25 11:44 ` [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands Ferruh Yigit
2022-05-23 7:10 ` [PATCH 6/6] net/ixgbe: move testpmd commands David Marchand
2022-05-23 18:09 ` [PATCH 0/6] Split driver specific commands out of testpmd Ferruh Yigit
2022-05-24 20:06 ` [PATCH v2 0/2] " David Marchand
2022-05-24 20:06 ` [PATCH v2 1/2] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-31 15:15 ` Andrew Rybchenko
2022-05-24 20:06 ` [PATCH v2 2/2] app/testpmd: register driver specific commands David Marchand
2022-05-24 20:28 ` Thomas Monjalon
2022-05-31 15:14 ` Andrew Rybchenko
2022-05-31 15:18 ` David Marchand
2022-05-31 15:18 ` [PATCH v2 0/2] Split driver specific commands out of testpmd Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=103050ec-70aa-9d28-fc42-7c40072196ff@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=aman.deep.singh@intel.com \
--cc=chas3@att.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).