From: Rasesh Mody <rasesh.mody@cavium.com>
To: <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: Rasesh Mody <rasesh.mody@cavium.com>, <Dept-EngDPDKDev@cavium.com>
Subject: [dpdk-dev] [PATCH v2 6/8] net/qede: set mdump flag
Date: Sat, 1 Jul 2017 12:30:00 -0700 [thread overview]
Message-ID: <1498937402-25547-7-git-send-email-rasesh.mody@cavium.com> (raw)
In-Reply-To: <1498729889-21524-1-git-send-email-rasesh.mody@cavium.com>
Set allow management FW dump flag during HW prepare.
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
drivers/net/qede/base/ecore.h | 2 +-
drivers/net/qede/base/ecore_dev.c | 1 +
drivers/net/qede/base/ecore_dev_api.h | 3 +++
drivers/net/qede/base/ecore_mcp.c | 3 +--
drivers/net/qede/qede_main.c | 1 +
5 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/qede/base/ecore.h b/drivers/net/qede/base/ecore.h
index d92988e..0d68a9b 100644
--- a/drivers/net/qede/base/ecore.h
+++ b/drivers/net/qede/base/ecore.h
@@ -770,7 +770,7 @@ struct ecore_dev {
bool attn_clr_en;
/* Indicates whether allowing the MFW to collect a crash dump */
- bool mdump_en;
+ bool allow_mdump;
/* Indicates if the reg_fifo is checked after any register access */
bool chk_reg_fifo;
diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c
index 138b986..4cfa668 100644
--- a/drivers/net/qede/base/ecore_dev.c
+++ b/drivers/net/qede/base/ecore_dev.c
@@ -3565,6 +3565,7 @@ enum _ecore_status_t ecore_hw_prepare(struct ecore_dev *p_dev,
enum _ecore_status_t rc;
p_dev->chk_reg_fifo = p_params->chk_reg_fifo;
+ p_dev->allow_mdump = p_params->allow_mdump;
if (p_params->b_relaxed_probe)
p_params->p_relaxed_res = ECORE_HW_PREPARE_SUCCESS;
diff --git a/drivers/net/qede/base/ecore_dev_api.h b/drivers/net/qede/base/ecore_dev_api.h
index e64a768..886407b 100644
--- a/drivers/net/qede/base/ecore_dev_api.h
+++ b/drivers/net/qede/base/ecore_dev_api.h
@@ -186,6 +186,9 @@ struct ecore_hw_prepare_params {
/* The OS Epoch time in seconds */
u32 epoch;
+ /* Allow the MFW to collect a crash dump */
+ bool allow_mdump;
+
/* Allow prepare to pass even if some initializations are failing.
* If set, the `p_prepare_res' field would be set with the return,
* and might allow probe to pass even if there are certain issues.
diff --git a/drivers/net/qede/base/ecore_mcp.c b/drivers/net/qede/base/ecore_mcp.c
index a834ac7..03cc901 100644
--- a/drivers/net/qede/base/ecore_mcp.c
+++ b/drivers/net/qede/base/ecore_mcp.c
@@ -1556,10 +1556,9 @@ static void ecore_mcp_handle_critical_error(struct ecore_hwfn *p_hwfn,
DP_NOTICE(p_hwfn, false,
"Received a critical error notification from the MFW!\n");
- if (p_hwfn->p_dev->mdump_en) {
+ if (p_hwfn->p_dev->allow_mdump) {
DP_NOTICE(p_hwfn, false,
"Not acknowledging the notification to allow the MFW crash dump\n");
- p_hwfn->p_dev->mdump_en = false;
return;
}
diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index 01584f8..a6ff7af 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -60,6 +60,7 @@ static void qed_init_pci(struct ecore_dev *edev, struct rte_pci_device *pci_dev)
hw_prepare_params.drv_resc_alloc = false;
hw_prepare_params.chk_reg_fifo = false;
hw_prepare_params.initiate_pf_flr = true;
+ hw_prepare_params.allow_mdump = false;
hw_prepare_params.epoch = (u32)time(NULL);
rc = ecore_hw_prepare(edev, &hw_prepare_params);
if (rc) {
--
1.7.10.3
next prev parent reply other threads:[~2017-07-01 19:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:51 [dpdk-dev] [PATCH 0/9] net/qede: update PMD to 2.5.1.1 Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 1/9] net/qede: fix DMA memory leak Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 2/9] net/qede: add notifying HW errors Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 3/9] net/qede: limit ring size to 32k Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 4/9] net/qede: comments traces and format changes Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 5/9] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 6/9] net/qede: set mdump flag Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 7/9] net/qede: add missing check for VNI Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 8/9] net/qede: use newer packet mbuf allocate API Rasesh Mody
2017-06-29 12:55 ` Ferruh Yigit
2017-07-01 19:34 ` Mody, Rasesh
2017-06-29 9:51 ` [dpdk-dev] [PATCH 9/9] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-06-29 12:16 ` [dpdk-dev] [PATCH 0/9] net/qede: update PMD " Ferruh Yigit
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 0/8] " Rasesh Mody
2017-07-05 10:01 ` Ferruh Yigit
2017-07-08 18:35 ` Mody, Rasesh
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 1/8] net/qede: fix DMA memory leak Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 2/8] net/qede: add notifying HW errors Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 3/8] net/qede: limit ring size to 32k Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 4/8] net/qede: comments traces and format changes Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 5/8] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-07-01 19:30 ` Rasesh Mody [this message]
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 7/8] net/qede: add missing check for VNI Rasesh Mody
2017-07-03 10:08 ` Ferruh Yigit
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 8/8] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-07-03 10:06 ` Ferruh Yigit
2017-07-05 9:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498937402-25547-7-git-send-email-rasesh.mody@cavium.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).