From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com
Subject: Re: [dpdk-dev] [PATCH v4] crypto/aesni_gcm: migration from MB library to ISA-L
Date: Thu, 05 Jan 2017 16:12:26 +0100 [thread overview]
Message-ID: <17462396.FW1IWXuNnf@xps13> (raw)
In-Reply-To: <1483624286-92526-1-git-send-email-piotrx.t.azarewicz@intel.com>
2017-01-05 14:51, Piotr Azarewicz:
> Current Cryptodev AES-NI GCM PMD is implemented using Multi Buffer
> Crypto library.This patch reimplement the device using ISA-L Crypto
> library: https://github.com/01org/isa-l_crypto.
>
> The migration entailed the following additional support for:
> * GMAC algorithm.
> * 256-bit cipher key.
> * Session-less mode.
> * Out-of place processing
> * Scatter-gatter support for chained mbufs (only out-of place and
> destination mbuf must be contiguous)
>
> Verified current unit tests and added new unit tests to verify new
> functionalities.
>
> PERFORMANCE COMPARISON
> ----------------------
> Comparison the new and old implementation is made by running app/test
> and calling cryptodev_aesni_gcm_perftest.
> As we may see below, the new implementation has small performance drop
> when buffer size is above 64B.
I am a bit surprised that you change for lower performance.
I understand that it brings new features.
Is it possible to add such features without performance impact?
> Old implementation with MB library:
> Cipher algo: AES_GCM Cipher hash: AES_GCM ciphr key: 128b burst size: 32
> Buffer Size(B) OPS(M) Throughput(Gbps) Retries EmptyPolls
> 64 4.57 2.34 0 0
> 128 4.28 4.39 0 0
> 256 2.76 5.66 0 0
> 512 1.60 6.56 0 0
> 1024 0.90 7.34 0 0
> 1536 0.62 7.66 0 0
> 2048 0.48 7.84 0 0
>
> New implementation with ISA-L library:
> Cipher algo: AES_GCM Cipher hash: AES_GCM ciphr key: 128b burst size: 32
> Buffer Size(B) OPS(M) Throughput(Gbps) Retries EmptyPolls
> 64 4.62 2.37 0 0
> 128 4.06 4.16 0 0
> 256 2.65 5.44 0 0
> 512 1.57 6.45 0 0
> 1024 0.89 7.26 0 0
> 1536 0.62 7.58 0 0
> 2048 0.47 7.77 0 0
>
next prev parent reply other threads:[~2017-01-05 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 18:53 [dpdk-dev] [PATCH v2] " Michal Jastrzebski
2017-01-03 13:02 ` [dpdk-dev] [PATCH v3] " Piotr Azarewicz
2017-01-03 14:14 ` Thomas Monjalon
2017-01-05 13:51 ` [dpdk-dev] [PATCH v4] " Piotr Azarewicz
2017-01-05 15:12 ` Thomas Monjalon [this message]
2017-01-16 12:37 ` [dpdk-dev] [PATCH v5] " Piotr Azarewicz
2017-01-16 14:42 ` Thomas Monjalon
2017-01-16 15:20 ` Mcnamara, John
2017-01-16 14:43 ` Thomas Monjalon
2017-01-17 7:42 ` Azarewicz, PiotrX T
2017-01-16 16:05 ` Declan Doherty
2017-01-17 11:19 ` [dpdk-dev] [PATCH v6 0/2] " Piotr Azarewicz
2017-01-17 11:19 ` [dpdk-dev] [PATCH v6 1/2] " Piotr Azarewicz
2017-01-17 11:19 ` [dpdk-dev] [PATCH v6 2/2] app/test: add GCM additional tests Piotr Azarewicz
2017-01-18 12:37 ` [dpdk-dev] [PATCH v6 0/2] crypto/aesni_gcm: migration from MB library to ISA-L De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17462396.FW1IWXuNnf@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).