From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, yliu@fridaylinux.org, lei.a.yao@intel.com
Cc: mst@redhat.com
Subject: Re: [dpdk-dev] [PATCH] vhost: postpone ring addresses translations at kick time only
Date: Fri, 3 Nov 2017 16:56:42 +0100 [thread overview]
Message-ID: <1d70c3b9-67c5-22d8-9312-33e43db0ac70@redhat.com> (raw)
In-Reply-To: <20171103155235.29869-1-maxime.coquelin@redhat.com>
Hi Lei,
On 11/03/2017 04:52 PM, Maxime Coquelin wrote:
> If multiple queue pairs are created but all are not used, the
> device is never started, as unused queues aren't enabled and
> their ring addresses aren't translated. The device is changed
> to running state when all rings addresses are translated.
>
> This patch fixes this by postponning rings addresses translation
> at kick time unconditionnaly, VHOST_USER_F_PROTOCOL_FEATURES
> being negotiated or not.
>
> Reported-by: Lei Yao<lei.a.yao@intel.com>
> Signed-off-by: Maxime Coquelin<maxime.coquelin@redhat.com>
> ---
> lib/librte_vhost/vhost_user.c | 33 ++++++++-------------------------
> 1 file changed, 8 insertions(+), 25 deletions(-)
Could you confirm the patch fixes the issue on your side?
I tested below cases with and without IOMMU:
- Host DPDK queues = 1 / QEMU queues = 1 / Guest DPDK queues = 1
- Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 1
- Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 2
Thanks,
Maxime
next prev parent reply other threads:[~2017-11-03 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 15:52 Maxime Coquelin
2017-11-03 15:56 ` Maxime Coquelin [this message]
2017-11-06 3:26 ` Yao, Lei A
2017-11-06 8:12 ` Maxime Coquelin
2017-11-06 11:58 ` Yuanhan Liu
2017-11-07 1:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d70c3b9-67c5-22d8-9312-33e43db0ac70@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=mst@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).