From: Jan Viktorin <viktorin@rehivetech.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/6] eal/arm: add 64-bit armv8 version of rte_memcpy.h
Date: Mon, 2 Nov 2015 18:29:10 +0100 [thread overview]
Message-ID: <20151102182910.275d3494@pcviktorin.fit.vutbr.cz> (raw)
In-Reply-To: <20151102162911.GC1869@localhost.localdomain>
On Mon, 2 Nov 2015 21:59:12 +0530
Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> On Mon, Nov 02, 2015 at 03:49:17PM +0000, Hunt, David wrote:
> > On 02/11/2015 15:36, Jan Viktorin wrote:
> > >On Mon, 2 Nov 2015 15:26:19 +0000
> > --snip--
> > >It was looking like we can share a lot of common code for both
> > >architectures. I didn't know how much different are the cpuflags.
> >
> > CPU flags for ARMv8 are looking like this now. Quite different to the ARMv7
> > ones.
> >
> > static const struct feature_entry cpu_feature_table[] = {
> > FEAT_DEF(FP, 0x00000001, 0, REG_HWCAP, 0)
> > FEAT_DEF(ASIMD, 0x00000001, 0, REG_HWCAP, 1)
> > FEAT_DEF(EVTSTRM, 0x00000001, 0, REG_HWCAP, 2)
> > FEAT_DEF(AES, 0x00000001, 0, REG_HWCAP, 3)
> > FEAT_DEF(PMULL, 0x00000001, 0, REG_HWCAP, 4)
> > FEAT_DEF(SHA1, 0x00000001, 0, REG_HWCAP, 5)
> > FEAT_DEF(SHA2, 0x00000001, 0, REG_HWCAP, 6)
> > FEAT_DEF(CRC32, 0x00000001, 0, REG_HWCAP, 7)
> > FEAT_DEF(AARCH32, 0x00000001, 0, REG_PLATFORM, 0)
> > FEAT_DEF(AARCH64, 0x00000001, 0, REG_PLATFORM, 1)
> > };
> >
> > >IMHO, it'd be better to have two directories arm and arm64. I thought
> > >to refer from arm64 to arm where possible. But I don't know whether is
> > >this possible with the DPDK build system.
> >
> > I think both methodologies have their pros and cons. However, I'd lean
> > towards the common directory with the "filename_32/64.h" scheme, as that
> > similar to the x86 methodology, and we don't need to tweak the include paths
> > to pull files from multiple directories.
> >
>
> I agree. Jan, could you please send the next version with
> filename_32/64.h for atomic and cpuflags(ie for all header files).
> I can re-base and send the complete arm64 patch based on your version.
>
I am working on it, however, after I've removed the unnecessary
intrinsics code and set the RTE_FORCE_INTRINSICS=y, it doesn't
build... So I'm figuring out what is wrong.
Jan
> Thanks,
> Jerin
>
>
>
> > Dave
> >
--
Jan Viktorin E-mail: Viktorin@RehiveTech.com
System Architect Web: www.RehiveTech.com
RehiveTech
Brno, Czech Republic
next prev parent reply other threads:[~2015-11-02 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 13:49 [dpdk-dev] [PATCH v3 0/6] ARMv8 additions to ARMv7 support David Hunt
2015-10-30 13:49 ` [dpdk-dev] [PATCH v3 1/6] eal/arm: add 64-bit armv8 version of rte_memcpy.h David Hunt
2015-11-02 4:57 ` Jerin Jacob
2015-11-02 12:22 ` Hunt, David
2015-11-02 12:45 ` Jan Viktorin
2015-11-02 12:57 ` Jerin Jacob
2015-11-02 15:26 ` Hunt, David
2015-11-02 15:36 ` Jan Viktorin
2015-11-02 15:49 ` Hunt, David
2015-11-02 16:29 ` Jerin Jacob
2015-11-02 17:29 ` Jan Viktorin [this message]
2015-10-30 13:49 ` [dpdk-dev] [PATCH v3 2/6] eal/arm: add 64-bit armv8 version of rte_prefetch.h David Hunt
2015-10-30 13:49 ` [dpdk-dev] [PATCH v3 3/6] eal/arm: add 64-bit armv8 version of rte_cycles.h David Hunt
2015-11-02 5:15 ` Jerin Jacob
2015-10-30 13:49 ` [dpdk-dev] [PATCH v3 4/6] eal/arm: fix 64-bit armv8 compilation of rte_cpuflags.h David Hunt
2015-10-30 13:49 ` [dpdk-dev] [PATCH v3 5/6] mk: add support for armv8 on top of armv7 David Hunt
2015-11-02 4:43 ` Jerin Jacob
2015-10-30 13:49 ` [dpdk-dev] [PATCH v3 6/6] test: add checks for cpu flags on armv8 David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102182910.275d3494@pcviktorin.fit.vutbr.cz \
--to=viktorin@rehivetech.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).