From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Liu, Yu Y" <yu.y.liu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset
Date: Thu, 20 Apr 2017 14:07:58 +0800 [thread overview]
Message-ID: <20170420060758.GA12462@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA0207A0EC@PGSMSX103.gar.corp.intel.com>
On Thu, Apr 06, 2017 at 02:57:29AM +0000, Zhao1, Wei wrote:
> > > + * Reset an ethernet device when it's not working. One scenario is,
> > > + after PF
> > > + * port is down and up, the related VF port should be reset.
> > > + * The API will stop the port, clear the rx/tx queues, re-setup the
> > > + rx/tx
> > > + * queues, restart the port.
> >
> > s/The API/This function/
> >
> > Please explain exactly the responsibility of this function, and how it is
> > different from calling stop/configure/start.
>
> In this reset feature, reset function can do the calling stop/configure/start process, but also
> It can also do some restore work for the port, for example, it can restore the added parameters
> of vlan, mac_addrs, promisc_unicast_enabled falg and promisc_multicast_enabled flag.
> Maybe , I should add this explanation in the patch comments or function comments?
I'm curious why we have to do save & restore for a reset operation.
Why some configures have to be saved and restored? Doesn't "reset"
literally means reset everything?
Even though, how do you tell what kind of configures need be restored
and what should not? Again, even though, will all PMDs supports
restoring the same set of configurations?
While looking at your reset implementation for i40e, it looks more
complex than necessary: just thinking we have to call "xxx_queue_setup"
for all PMDs.
I'm thinking a simple hardware reset might be enough?
/* literally reset the hardware: reset everything */
rte_eth_reset(port)
{
eth_dev->ops->reset();
}
Assume the application already has a function (say, port_init()) to
initiate a specific port, it then just needs do something like following
to handle the case you described in the commit log:
rte_eth_reset(port);
port_init(port);
Makes sense? Sorry it's completely wrong; I've limited knowledge on NIC
pmd drivers after all :/
--yliu
next prev parent reply other threads:[~2017-04-20 6:11 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 9:34 [dpdk-dev] [PATCH v4 0/3] net/i40e: vf " Wei Zhao
2017-03-30 9:34 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for " Wei Zhao
2017-03-30 19:55 ` Thomas Monjalon
2017-04-06 2:57 ` Zhao1, Wei
2017-04-06 7:11 ` Thomas Monjalon
2017-04-06 8:53 ` Zhao1, Wei
2017-04-06 9:02 ` Ananyev, Konstantin
2017-04-10 20:58 ` Thomas Monjalon
2017-04-13 8:55 ` Zhao1, Wei
2017-04-13 10:06 ` Thomas Monjalon
2017-04-14 1:29 ` Zhao1, Wei
2017-04-14 6:31 ` Thomas Monjalon
2017-04-14 8:03 ` Zhao1, Wei
2017-04-17 2:08 ` Zhao1, Wei
2017-04-17 5:02 ` Zhao1, Wei
2017-04-20 6:07 ` Yuanhan Liu [this message]
2017-04-20 9:17 ` Zhao1, Wei
2017-04-21 2:27 ` Yuanhan Liu
2017-04-21 8:27 ` Thomas Monjalon
2017-04-21 8:59 ` Zhao1, Wei
2017-04-21 9:28 ` Thomas Monjalon
2017-04-24 2:01 ` Yuanhan Liu
2017-04-24 3:15 ` Zhao1, Wei
2017-04-24 3:39 ` Zhao1, Wei
2017-04-24 8:04 ` Thomas Monjalon
2017-04-25 3:14 ` Zhao1, Wei
2017-04-21 8:55 ` Zhao1, Wei
2017-03-30 9:34 ` [dpdk-dev] [PATCH v4 2/3] net/i40e: implement device reset on port Wei Zhao
2017-03-30 9:34 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-03-30 12:32 ` [dpdk-dev] [PATCH v4 0/3] net/i40e: vf port reset Wu, Jingjing
2017-04-05 5:42 ` Zhao1, Wei
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 " Wei Zhao
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-06 6:33 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 0/3] net/i40e: vf port reset Wei Zhao
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-07 6:58 ` Yang, Qiming
2017-04-10 2:21 ` Zhao1, Wei
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-06 6:51 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 0/3] net/i40e: vf port reset Wei Zhao
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 1/3] lib/librte_ether: add support for " Wei Zhao
2017-04-20 20:49 ` Thomas Monjalon
2017-04-21 3:20 ` Zhao1, Wei
2017-04-20 20:52 ` Thomas Monjalon
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port Wei Zhao
2017-04-20 21:12 ` Thomas Monjalon
2017-04-21 3:39 ` Zhao1, Wei
2017-04-20 21:20 ` Thomas Monjalon
2017-04-10 3:02 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add port reset command into testpmd Wei Zhao
2017-04-20 21:37 ` [dpdk-dev] [PATCH v7 0/3] net/i40e: vf port reset Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-03-30 9:21 [dpdk-dev] [PATCH v4 " Wei Zhao
2017-03-30 9:21 ` [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for " Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420060758.GA12462@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yu.y.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).