From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: declan.doherty@intel.com, thomas@monjalon.net, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
Date: Thu, 8 Jun 2017 00:54:41 +0200 [thread overview]
Message-ID: <20170607225441.GX18840@bidouze.vm.6wind.com> (raw)
In-Reply-To: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>
Hi Pablo,
On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote:
> Following the same aproach taken for ethdev, this patch series
> removes the PCI specific structure cryptodev driver from rte_cryptodev.
>
> The patchset makes the following changes:
>
> - Moves the virtual and PCI device specific functions to separate files,
> so other cryptodev header files contain only device type agnostic functions.
>
> - Modifies device info retrieval function to set the driver name for all devices
> and set PCI info inside PCI device PMDs
>
> - Removes cryptodev driver structure from cryptodev library and drivers
> that were using it (QAT and dpaa2)
>
While most of the work seems to be done within this patchset, there are
still rte_pci.h includes in both:
lib/librte_cryptodev/rte_cryptodev.c:50:#include <rte_pci.h>
lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include <rte_pci.h>
This breaks the compilation when the PCI bus is compiled outside the EAL.
Would you be able to remove those last dependencies?
> There is still a vdev specific function, rte_cryptodev_create_vdev() in cryptodev.c.
> That function should be deprecated, as virtual devices should be created through
> EAL. A deprecation notice will be sent separately.
>
> Pablo de Lara (12):
> cryptodev: store device pointer in virtual devices
> cryptodev: set driver name for all devices
> cryptodev: rename device retrieval argument
> cryptodev: simplify device list retrieval logic
> cryptodev: only set PCI info when device is PCI
> cryptodev: move vdev functions to a separate file
> cryptodev: release device if PCI device probing fails
> cryptodev: add PCI driver helpers
> crypto/qat: do not use cryptodev driver
> crypto/dpaa2_sec: do not use cryptodev driver
> cryptodev: remove unused PCI probe/remove
> cryptodev: remove unused cryptodev driver
>
> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 +-
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 5 +-
> drivers/crypto/armv8/rte_armv8_pmd.c | 4 +-
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 9 +-
> drivers/crypto/kasumi/rte_kasumi_pmd.c | 4 +-
> drivers/crypto/null/null_crypto_pmd.c | 8 +-
> drivers/crypto/openssl/rte_openssl_pmd.c | 4 +-
> drivers/crypto/qat/qat_crypto.c | 6 +-
> drivers/crypto/qat/qat_qp.c | 8 +-
> drivers/crypto/qat/rte_qat_cryptodev.c | 32 +--
> drivers/crypto/scheduler/scheduler_pmd.c | 59 +-----
> drivers/crypto/scheduler/scheduler_pmd_ops.c | 1 +
> drivers/crypto/snow3g/rte_snow3g_pmd.c | 4 +-
> drivers/crypto/zuc/rte_zuc_pmd.c | 4 +-
> lib/librte_cryptodev/Makefile | 2 +
> lib/librte_cryptodev/rte_cryptodev.c | 272 +------------------------
> lib/librte_cryptodev/rte_cryptodev.h | 39 +---
> lib/librte_cryptodev/rte_cryptodev_pci.h | 177 ++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 94 ---------
> lib/librte_cryptodev/rte_cryptodev_vdev.h | 236 +++++++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev_version.map | 18 +-
> 21 files changed, 497 insertions(+), 493 deletions(-)
> create mode 100644 lib/librte_cryptodev/rte_cryptodev_pci.h
> create mode 100644 lib/librte_cryptodev/rte_cryptodev_vdev.h
>
> --
> 2.7.4
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2017-06-07 22:54 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 15:27 Pablo de Lara
2017-05-24 15:27 ` [dpdk-dev] [PATCH 01/12] cryptodev: store device pointer in virtual devices Pablo de Lara
2017-06-20 14:34 ` Declan Doherty
2017-06-20 17:29 ` De Lara Guarch, Pablo
2017-05-24 15:27 ` [dpdk-dev] [PATCH 02/12] cryptodev: set driver name for all devices Pablo de Lara
2017-06-20 14:34 ` Declan Doherty
2017-05-24 15:27 ` [dpdk-dev] [PATCH 03/12] cryptodev: rename device retrieval argument Pablo de Lara
2017-06-20 14:35 ` Declan Doherty
2017-06-20 17:28 ` De Lara Guarch, Pablo
2017-05-24 15:27 ` [dpdk-dev] [PATCH 04/12] cryptodev: simplify device list retrieval logic Pablo de Lara
2017-06-20 14:35 ` Declan Doherty
2017-06-20 17:29 ` De Lara Guarch, Pablo
2017-05-24 15:27 ` [dpdk-dev] [PATCH 05/12] cryptodev: only set PCI info when device is PCI Pablo de Lara
2017-06-20 14:36 ` Declan Doherty
2017-05-24 15:27 ` [dpdk-dev] [PATCH 06/12] cryptodev: move vdev functions to a separate file Pablo de Lara
2017-06-20 14:36 ` Declan Doherty
2017-06-20 21:46 ` De Lara Guarch, Pablo
2017-05-24 15:27 ` [dpdk-dev] [PATCH 07/12] cryptodev: release device if PCI device probing fails Pablo de Lara
2017-06-20 14:36 ` Declan Doherty
2017-05-24 15:27 ` [dpdk-dev] [PATCH 08/12] cryptodev: add PCI driver helpers Pablo de Lara
2017-06-20 14:37 ` Declan Doherty
2017-05-24 15:27 ` [dpdk-dev] [PATCH 09/12] crypto/qat: do not use cryptodev driver Pablo de Lara
2017-06-20 14:37 ` Declan Doherty
2017-05-24 15:27 ` [dpdk-dev] [PATCH 10/12] crypto/dpaa2_sec: " Pablo de Lara
2017-05-24 15:27 ` [dpdk-dev] [PATCH 11/12] cryptodev: remove unused PCI probe/remove Pablo de Lara
2017-06-20 14:37 ` Declan Doherty
2017-05-24 15:27 ` [dpdk-dev] [PATCH 12/12] cryptodev: remove unused cryptodev driver Pablo de Lara
2017-06-20 14:37 ` Declan Doherty
2017-06-07 22:54 ` Gaëtan Rivet [this message]
2017-06-08 15:58 ` [dpdk-dev] [PATCH 00/12] Remove " De Lara Guarch, Pablo
2017-06-09 9:58 ` Gaëtan Rivet
2017-06-09 10:01 ` De Lara Guarch, Pablo
2017-06-09 10:29 ` De Lara Guarch, Pablo
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 00/12] Remove cryptodev driver structure Pablo de Lara
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 01/12] cryptodev: store device pointer in virtual devices Pablo de Lara
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 02/12] cryptodev: set driver name for all devices Pablo de Lara
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 03/12] cryptodev: rename device retrieval argument Pablo de Lara
2017-06-23 12:54 ` Declan Doherty
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 04/12] cryptodev: simplify device list retrieval logic Pablo de Lara
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 05/12] cryptodev: only set PCI info when device is PCI Pablo de Lara
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file Pablo de Lara
2017-06-23 12:52 ` Declan Doherty
2017-06-26 23:30 ` Thomas Monjalon
2017-06-27 9:51 ` De Lara Guarch, Pablo
2017-06-27 14:28 ` Thomas Monjalon
2017-06-27 15:11 ` Ferruh Yigit
2017-06-27 16:09 ` Thomas Monjalon
2017-06-27 17:11 ` De Lara Guarch, Pablo
2017-06-27 22:22 ` De Lara Guarch, Pablo
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 07/12] cryptodev: release device if PCI device probing fails Pablo de Lara
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 08/12] cryptodev: add PCI driver helpers Pablo de Lara
2017-06-29 21:21 ` Thomas Monjalon
2017-06-21 6:28 ` [dpdk-dev] [PATCH v2 09/12] crypto/qat: do not use cryptodev driver Pablo de Lara
2017-06-23 15:18 ` [dpdk-dev] [PATCH v2 00/12] Remove cryptodev driver structure De Lara Guarch, Pablo
2017-06-21 6:30 ` [dpdk-dev] [PATCH v2 10/12] crypto/dpaa2_sec: do not use cryptodev driver Pablo de Lara
2017-06-21 6:30 ` [dpdk-dev] [PATCH v2 11/12] cryptodev: remove unused PCI probe/remove Pablo de Lara
2017-06-21 6:30 ` [dpdk-dev] [PATCH v2 12/12] cryptodev: remove unused cryptodev driver Pablo de Lara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607225441.GX18840@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).