From: Bruce Richardson <bruce.richardson@intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, xen-devel@lists.xenproject.org,
thomas@monjalon.net, john.mcnamara@intel.com,
oao.m.martins@oracle.com, jerin.jacob@caviumnetworks.com,
shahafs@mellanox.com
Subject: Re: [dpdk-dev] [PATCH 2/6] net/xenvirt: remove
Date: Mon, 4 Sep 2017 15:25:48 +0100 [thread overview]
Message-ID: <20170904142548.GC11856@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1504116634-115687-3-git-send-email-jianfeng.tan@intel.com>
On Wed, Aug 30, 2017 at 06:10:30PM +0000, Jianfeng Tan wrote:
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> MAINTAINERS | 2 -
> app/test-pmd/Makefile | 4 -
> app/test-pmd/testpmd.c | 12 -
> config/common_base | 5 -
> config/defconfig_arm-armv7a-linuxapp-gcc | 1 -
> doc/guides/nics/features/xenvirt.ini | 6 -
> drivers/net/Makefile | 2 -
> drivers/net/xenvirt/Makefile | 57 --
> drivers/net/xenvirt/rte_eth_xenvirt.c | 766 ------------------------
> drivers/net/xenvirt/rte_eth_xenvirt.h | 61 --
> drivers/net/xenvirt/rte_eth_xenvirt_version.map | 7 -
> drivers/net/xenvirt/rte_mempool_gntalloc.c | 295 ---------
> drivers/net/xenvirt/rte_xen_lib.c | 454 --------------
> drivers/net/xenvirt/rte_xen_lib.h | 116 ----
> drivers/net/xenvirt/virtio_logs.h | 70 ---
> drivers/net/xenvirt/virtqueue.h | 273 ---------
> mk/rte.app.mk | 1 -
> pkg/dpdk.spec | 3 -
> 18 files changed, 2135 deletions(-)
> delete mode 100644 doc/guides/nics/features/xenvirt.ini
> delete mode 100644 drivers/net/xenvirt/Makefile
> delete mode 100644 drivers/net/xenvirt/rte_eth_xenvirt.c
> delete mode 100644 drivers/net/xenvirt/rte_eth_xenvirt.h
> delete mode 100644 drivers/net/xenvirt/rte_eth_xenvirt_version.map
> delete mode 100644 drivers/net/xenvirt/rte_mempool_gntalloc.c
> delete mode 100644 drivers/net/xenvirt/rte_xen_lib.c
> delete mode 100644 drivers/net/xenvirt/rte_xen_lib.h
> delete mode 100644 drivers/net/xenvirt/virtio_logs.h
> delete mode 100644 drivers/net/xenvirt/virtqueue.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe6c6db..003e72e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -194,9 +194,7 @@ M: Jianfeng Tan <jianfeng.tan@intel.com>
> F: lib/librte_eal/linuxapp/xen_dom0/
> F: lib/librte_eal/linuxapp/eal/*xen*
> F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
> -F: drivers/net/xenvirt/
> F: doc/guides/xen/
> -F: doc/guides/nics/features/xenvirt.ini
>
> FreeBSD EAL (with overlaps)
> M: Bruce Richardson <bruce.richardson@intel.com>
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> index c36be19..b6e80dd 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -77,10 +77,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
> LDLIBS += -lrte_pmd_bnxt
> endif
>
> -ifeq ($(CONFIG_RTE_LIBRTE_PMD_XENVIRT),y)
> -LDLIBS += -lrte_pmd_xenvirt
> -endif
> -
> endif
>
> CFLAGS_cmdline.o := -D_GNU_SOURCE
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 7d40139..f8d02ae 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -76,9 +76,6 @@
> #ifdef RTE_LIBRTE_IXGBE_PMD
> #include <rte_pmd_ixgbe.h>
> #endif
> -#ifdef RTE_LIBRTE_PMD_XENVIRT
> -#include <rte_eth_xenvirt.h>
> -#endif
> #ifdef RTE_LIBRTE_PDUMP
> #include <rte_pdump.h>
> #endif
> @@ -497,15 +494,6 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
> "create a new mbuf pool <%s>: n=%u, size=%u, socket=%u\n",
> pool_name, nb_mbuf, mbuf_seg_size, socket_id);
>
> -#ifdef RTE_LIBRTE_PMD_XENVIRT
> - rte_mp = rte_mempool_gntalloc_create(pool_name, nb_mbuf, mb_size,
> - (unsigned) mb_mempool_cache,
> - sizeof(struct rte_pktmbuf_pool_private),
> - rte_pktmbuf_pool_init, NULL,
> - rte_pktmbuf_init, NULL,
> - socket_id, 0);
> -#endif
> -
> /* if the former XEN allocation failed fall back to normal allocation */
> if (rte_mp == NULL) {
Remove comment and if condition, as there is no way the the variable can
be non-null now.
/Bruce
next prev parent reply other threads:[~2017-09-04 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 18:10 [dpdk-dev] [PATCH 0/6] remove xen dom0 support in DPDK Jianfeng Tan
2017-08-30 18:10 ` [dpdk-dev] [PATCH 1/6] example/vhost_xen: remove Jianfeng Tan
2017-09-04 14:14 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 2/6] net/xenvirt: remove Jianfeng Tan
2017-09-04 14:25 ` Bruce Richardson [this message]
2017-09-04 14:50 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test Jianfeng Tan
2017-09-04 14:24 ` Bruce Richardson
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 4/6] xen: remove xen dependency in drivers, ether, mempool Jianfeng Tan
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support Jianfeng Tan
2017-09-04 14:43 ` Bruce Richardson
2017-09-04 14:49 ` Bruce Richardson
2017-09-05 3:41 ` Tan, Jianfeng
2017-09-05 7:31 ` Thomas Monjalon
2017-09-05 8:07 ` Tan, Jianfeng
2017-09-05 8:34 ` Thomas Monjalon
2017-08-30 18:10 ` [dpdk-dev] [PATCH 6/6] eal: remove API rte_mem_phy2mch Jianfeng Tan
2017-09-04 14:52 ` Bruce Richardson
2017-08-31 8:44 ` [dpdk-dev] [Xen-devel] [PATCH 0/6] remove xen dom0 support in DPDK Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904142548.GC11856@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianfeng.tan@intel.com \
--cc=john.mcnamara@intel.com \
--cc=oao.m.martins@oracle.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).