From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 2/3] crypto: fix pedentic compilation errors
Date: Wed, 22 Nov 2017 11:35:55 +0100 [thread overview]
Message-ID: <20171122103555.qjw2ysr24l2iyzud@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC4C4EF@IRSMSX108.ger.corp.intel.com>
Hi Pablo,
On Wed, Nov 22, 2017 at 09:48:47AM +0000, De Lara Guarch, Pablo wrote:
> Hi Nelio,
>
> > -----Original Message-----
> > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> > Sent: Wednesday, November 22, 2017 8:10 AM
> > To: Akhil Goyal <akhil.goyal@nxp.com>; Doherty, Declan
> > <declan.doherty@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [PATCH 2/3] crypto: fix pedentic compilation errors
> >
> > /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_crypto.h:126:28:
> > error: ISO C forbids zero-size array ‘sym’ [-Werror=pedantic]
> > struct rte_crypto_sym_op sym[0];
> > ^~~
> >
> > Fixes: d2a4223c4c6d ("cryptodev: do not store pointer to op specific
> > params")
> > Cc: pablo.de.lara.guarch@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> > lib/librte_cryptodev/rte_crypto.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_cryptodev/rte_crypto.h
> > b/lib/librte_cryptodev/rte_crypto.h
> > index 3d672fe7d..dc6e91d1d 100644
> > --- a/lib/librte_cryptodev/rte_crypto.h
> > +++ b/lib/librte_cryptodev/rte_crypto.h
> > @@ -123,7 +123,7 @@ struct rte_crypto_op {
> >
> > RTE_STD_C11
> > union {
> > - struct rte_crypto_sym_op sym[0];
> > + struct rte_crypto_sym_op *sym;
>
> This would add extra 64 bits that are not necessary,
> as the rte_crypto_sym_op structure is always placed after rte_crypto_op
> (this is just a marker).
>
> Is there any other way to fix this error?
Indeed it is not the correct solution, the point here is RTE_STD_C11 is
wrongly used because even in C11 arrays with size of 0 are not
allowed. If it was the last attribute of the structure it could have
been replaced with empty brackets but as it is inside an union, it
cannot. The correct solution is to replace the RTE_STD_C11 by
__extension__.
> Which compiler are you using?
It occurs with any compiler when you enable the pedantic flag under C11.
All DPDK headers have been fix to avoid such issue [1].
Thanks,
[1] http://dpdk.org/ml/archives/dev/2016-April/037051.html
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-11-22 10:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 8:10 [dpdk-stable] [PATCH 1/3] security: fix device operation type Nelio Laranjeiro
2017-11-22 8:10 ` [dpdk-stable] [PATCH 2/3] crypto: fix pedentic compilation errors Nelio Laranjeiro
2017-11-22 9:48 ` De Lara Guarch, Pablo
2017-11-22 10:35 ` Nelio Laranjeiro [this message]
2017-11-22 13:56 ` [dpdk-stable] [dpdk-dev] " Neil Horman
2017-11-22 14:31 ` Gaëtan Rivet
2017-11-22 16:50 ` De Lara Guarch, Pablo
2017-11-22 8:10 ` [dpdk-stable] [PATCH 3/3] security: fix pedentic compilation Nelio Laranjeiro
2017-11-23 10:02 ` [dpdk-stable] [PATCH v2 1/3] security: fix device operation type Nelio Laranjeiro
2017-11-24 9:33 ` Akhil Goyal
2017-11-24 12:07 ` Nelio Laranjeiro
2018-01-08 9:58 ` De Lara Guarch, Pablo
2018-01-08 10:05 ` Akhil Goyal
2018-01-08 12:34 ` De Lara Guarch, Pablo
2017-11-23 10:02 ` [dpdk-stable] [PATCH v2 2/3] crypto: fix pedantic compilation errors Nelio Laranjeiro
2017-12-11 11:49 ` De Lara Guarch, Pablo
2017-12-11 12:42 ` Nelio Laranjeiro
2017-12-11 13:54 ` De Lara Guarch, Pablo
2017-12-11 14:16 ` Nelio Laranjeiro
2018-01-08 10:00 ` [dpdk-stable] [dpdk-dev] " De Lara Guarch, Pablo
2018-01-08 12:35 ` [dpdk-stable] " De Lara Guarch, Pablo
2017-11-23 10:02 ` [dpdk-stable] [PATCH v2 3/3] security: fix pedantic compilation Nelio Laranjeiro
2017-11-24 9:34 ` Akhil Goyal
2018-01-08 12:35 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122103555.qjw2ysr24l2iyzud@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).