From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation errors
Date: Mon, 8 Jan 2018 10:00:28 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC6963B@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20171211141626.ervyhyzchhsfvxl5@laranjeiro-vm.dev.6wind.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Monday, December 11, 2017 2:16 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; Doherty, Declan
> <declan.doherty@intel.com>; dev@dpdk.org; Gaetan Rivet
> <gaetan.rivet@6wind.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/3] crypto: fix pedantic compilation
> errors
>
> On Mon, Dec 11, 2017 at 01:54:22PM +0000, De Lara Guarch, Pablo wrote:
> >
> >
> > > -----Original Message-----
> > > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> > > Sent: Monday, December 11, 2017 12:43 PM
> > > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > > Cc: Akhil Goyal <akhil.goyal@nxp.com>; Doherty, Declan
> > > <declan.doherty@intel.com>; dev@dpdk.org; Gaetan Rivet
> > > <gaetan.rivet@6wind.com>; stable@dpdk.org
> > > Subject: Re: [PATCH v2 2/3] crypto: fix pedantic compilation errors
> > >
> > > Hi Pablo,
> > >
> > > On Mon, Dec 11, 2017 at 11:49:39AM +0000, De Lara Guarch, Pablo
> wrote:
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> > > > > Sent: Thursday, November 23, 2017 10:03 AM
> > > > > To: Akhil Goyal <akhil.goyal@nxp.com>; Doherty, Declan
> > > > > <declan.doherty@intel.com>
> > > > > Cc: dev@dpdk.org; Gaetan Rivet <gaetan.rivet@6wind.com>; De
> Lara
> > > > > Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > > > > Subject: [PATCH v2 2/3] crypto: fix pedantic compilation errors
> > > > >
> > > >
> > > > ...
> > > >
> > > > > --- a/lib/librte_cryptodev/rte_crypto.h
> > > > > +++ b/lib/librte_cryptodev/rte_crypto.h
> > > > > @@ -121,7 +121,7 @@ struct rte_crypto_op {
> > > > > rte_iova_t phys_addr;
> > > > > /**< physical address of crypto operation */
> > > > >
> > > > > - RTE_STD_C11
> > > > > + __extension__
> > > >
> > > > Hi Nelio,
> > > >
> > > > Since RTE_STD_C11 is basically __extension__ when
> __STDC_VERSION__
> > > is
> > > > not defined, Is this forcing __extension__ to be used no matter what?
> > > (even if C11 is not supported).
> > >
> > > Yes
> > >
> >
> > Right, and are we sure that this is OK? If C11 is supported, do we
> > still want extension?
>
> Having an array with an empty size inside a union does not make part of
> any standard, it is an extension of the language.
If no other objections from the community:
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>#
>
> Regards,
>
> --
> Nélio Laranjeiro
> 6WIND
next prev parent reply other threads:[~2018-01-08 10:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 8:10 [dpdk-stable] [PATCH 1/3] security: fix device operation type Nelio Laranjeiro
2017-11-22 8:10 ` [dpdk-stable] [PATCH 2/3] crypto: fix pedentic compilation errors Nelio Laranjeiro
2017-11-22 9:48 ` De Lara Guarch, Pablo
2017-11-22 10:35 ` Nelio Laranjeiro
2017-11-22 13:56 ` [dpdk-stable] [dpdk-dev] " Neil Horman
2017-11-22 14:31 ` Gaëtan Rivet
2017-11-22 16:50 ` De Lara Guarch, Pablo
2017-11-22 8:10 ` [dpdk-stable] [PATCH 3/3] security: fix pedentic compilation Nelio Laranjeiro
2017-11-23 10:02 ` [dpdk-stable] [PATCH v2 1/3] security: fix device operation type Nelio Laranjeiro
2017-11-24 9:33 ` Akhil Goyal
2017-11-24 12:07 ` Nelio Laranjeiro
2018-01-08 9:58 ` De Lara Guarch, Pablo
2018-01-08 10:05 ` Akhil Goyal
2018-01-08 12:34 ` De Lara Guarch, Pablo
2017-11-23 10:02 ` [dpdk-stable] [PATCH v2 2/3] crypto: fix pedantic compilation errors Nelio Laranjeiro
2017-12-11 11:49 ` De Lara Guarch, Pablo
2017-12-11 12:42 ` Nelio Laranjeiro
2017-12-11 13:54 ` De Lara Guarch, Pablo
2017-12-11 14:16 ` Nelio Laranjeiro
2018-01-08 10:00 ` De Lara Guarch, Pablo [this message]
2018-01-08 12:35 ` De Lara Guarch, Pablo
2017-11-23 10:02 ` [dpdk-stable] [PATCH v2 3/3] security: fix pedantic compilation Nelio Laranjeiro
2017-11-24 9:34 ` Akhil Goyal
2018-01-08 12:35 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC6963B@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).