From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
Shahaf shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling
Date: Mon, 26 Mar 2018 11:34:33 +0200 [thread overview]
Message-ID: <20180326093433.GD4011@6wind.com> (raw)
In-Reply-To: <1522009169-13860-1-git-send-email-ophirmu@mellanox.com>
On Sun, Mar 25, 2018 at 08:19:29PM +0000, Ophir Munk wrote:
> Previous to this commit mlx4 CRC stripping was executed by default and
> there was no verbs API to disable it.
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
> v1: initial version
> v2: following internal reviews
> v3: following dpdk.org mailing list reviews
Except for the remaining extra space mentioned below :)
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
<snip>
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index ee93daf..eea6e93 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -562,7 +562,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> (device_attr.vendor_part_id ==
> PCI_DEVICE_ID_MELLANOX_CONNECTX3PRO);
> DEBUG("L2 tunnel checksum offloads are %ssupported",
> - (priv->hw_csum_l2tun ? "" : "not "));
> + priv->hw_csum_l2tun ? "" : "not ");
> priv->hw_rss_sup = device_attr_ex.rss_caps.rx_hash_fields_mask;
> if (!priv->hw_rss_sup) {
> WARN("no RSS capabilities reported; disabling support"
> @@ -578,6 +578,10 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> }
> DEBUG("supported RSS hash fields mask: %016" PRIx64,
> priv->hw_rss_sup);
> + priv->hw_fcs_strip = !!(device_attr_ex.raw_packet_caps &
> + IBV_RAW_PACKET_CAP_SCATTER_FCS);
I know the extra space before IBV_RAW_PACKET_CAP_SCATTER_FCS is present in
the original mlx5 code, but it's misaligned there also. This line should be
aligned with "device_attr_ex.raw_packet_caps" for consistency.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-03-26 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 9:00 [dpdk-dev] [PATCH v1] net/mlx4: disable CRC stripping Ophir Munk
2018-03-19 16:36 ` [dpdk-dev] [PATCH v2] net/mlx4: support CRC strip toggling Ophir Munk
2018-03-23 14:53 ` Adrien Mazarguil
2018-03-25 16:17 ` Ophir Munk
2018-03-25 20:19 ` [dpdk-dev] [PATCH v3] " Ophir Munk
2018-03-26 9:34 ` Adrien Mazarguil [this message]
2018-04-10 6:26 ` Shahaf Shuler
2018-03-26 11:38 ` Ferruh Yigit
2018-03-26 11:54 ` Adrien Mazarguil
2018-03-26 12:30 ` Thomas Monjalon
2018-03-28 6:03 ` Shahaf Shuler
2018-03-28 14:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326093433.GD4011@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).